From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: "Karicheri, Muralidharan" <m-karicheri2@ti.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"sakari.ailus@maxwell.research.nokia.com"
<sakari.ailus@maxwell.research.nokia.com>
Subject: Re: [RFC/PATCH 2/6] v4l: subdev: Add device node support
Date: Wed, 07 Jul 2010 12:08:28 -0300 [thread overview]
Message-ID: <4C34986C.6020806@redhat.com> (raw)
In-Reply-To: <A69FA2915331DC488A831521EAE36FE4016B5EDCD7@dlee06.ent.ti.com>
Em 07-07-2010 11:14, Karicheri, Muralidharan escreveu:
>
>
>> v4l2_device *v4l2_dev,
>> if (err && err != -ENOIOCTLCMD) {
>> v4l2_device_unregister_subdev(sd);
>> sd = NULL;
>> + } else {
>> + sd->initialized = 1;
>> }
>
> Wouldn't checkpatch.pl script complain about { } on the else part since
> there is only one statement?
IMO, it is because it analyzes the entire if clause. As the first part of the if has two
statements, CodingStyle accepts the usage of braces at the second part
(although this is not a common practice).
>> }
>>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-07-07 15:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 11:53 [RFC/PATCH 0/6] V4L2 subdev userspace API Laurent Pinchart
2010-07-07 11:53 ` [RFC/PATCH 1/6] v4l: subdev: Don't require core operations Laurent Pinchart
2010-07-07 12:21 ` Hans Verkuil
2010-07-07 14:05 ` Karicheri, Muralidharan
2010-07-07 11:53 ` [RFC/PATCH 2/6] v4l: subdev: Add device node support Laurent Pinchart
2010-07-07 12:30 ` Hans Verkuil
2010-07-07 12:53 ` Laurent Pinchart
2010-07-07 13:04 ` Hans Verkuil
2010-07-08 12:01 ` Laurent Pinchart
2010-07-08 12:34 ` Hans Verkuil
2010-07-07 12:43 ` Hans Verkuil
2010-07-07 14:00 ` Laurent Pinchart
2010-07-07 14:14 ` Karicheri, Muralidharan
2010-07-07 14:39 ` Sylwester Nawrocki
2010-07-07 15:08 ` Mauro Carvalho Chehab [this message]
2010-07-08 7:20 ` Pawel Osciak
2010-07-07 14:58 ` Mauro Carvalho Chehab
2010-07-07 19:44 ` Laurent Pinchart
2010-07-07 20:53 ` Mauro Carvalho Chehab
2010-07-08 12:08 ` Laurent Pinchart
2010-07-08 13:51 ` Mauro Carvalho Chehab
2010-07-09 8:57 ` Laurent Pinchart
2010-07-07 11:53 ` [RFC/PATCH 3/6] v4l: subdev: Uninline the v4l2_subdev_init function Laurent Pinchart
2010-07-07 12:31 ` Hans Verkuil
2010-07-07 11:53 ` [RFC/PATCH 4/6] v4l: subdev: Control ioctls support Laurent Pinchart
2010-07-07 12:33 ` Hans Verkuil
2010-07-07 12:35 ` Laurent Pinchart
2010-07-07 11:53 ` [RFC/PATCH 5/6] v4l: subdev: Events support Laurent Pinchart
2010-07-07 12:37 ` Hans Verkuil
2010-07-07 11:53 ` [RFC/PATCH 6/6] v4l: subdev: Generic ioctl support Laurent Pinchart
2010-07-07 12:38 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C34986C.6020806@redhat.com \
--to=mchehab@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=sakari.ailus@maxwell.research.nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.