From: Andi Kleen <ak@linux.intel.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Alok Kataria <akataria@vmware.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
"lenb@kernel.org" <lenb@kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Petr Vandrovec <petr@vmware.com>
Subject: Re: swiotlb detection should be memory hotplug aware ?
Date: Fri, 23 Jul 2010 16:33:32 +0200 [thread overview]
Message-ID: <4C49A83C.8070203@linux.intel.com> (raw)
In-Reply-To: <20100723142208.GA4008@phenom.dumpdata.com>
> I thought SRAT has NUMA affinity information - so for example my AMD
> desktop box has that, but it does not support hotplug capability.
>
> I think first your 'hotplug_possible' code needs to be more specific -
> not just check if SRAT exists, but also if there are swaths of memory
> that are non-populated. It would also help if there was some indication
> of whether the box truly does a hardware hotplug - is there a way to do
> this?
The SRAT declares hotplug memory ranges in advance. And Linux already
uses this
information in the SRAT parser (just the code for doing this is a bit
dumb, I have a rewrite
somewhere)
The only drawback is that some older systems claimed to have large
hotplug memory ranges
when they didn't actually support it. So it's better to not do anything
with a lot
of overhead.
So yes it would be reasonable to let swiotlb (and possibly other code
sizing itself
based on memory) call into the SRAT parser and check the hotplug ranges too.
BTW longer term swiotlb should be really more dynamic anyways and grow
and shrink on demand. I attempted this some time ago with my DMA
allocator patchkit,
unfortunately that didn't go forward.
-Andi
next prev parent reply other threads:[~2010-07-23 14:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-13 2:07 swiotlb detection should be memory hotplug aware ? Alok Kataria
2010-03-13 3:09 ` Andi Kleen
2010-03-15 17:22 ` Alok Kataria
2010-03-16 0:51 ` [LKML] " Konrad Rzeszutek Wilk
2010-03-16 1:33 ` FUJITA Tomonori
2010-03-16 12:45 ` [LKML] " Konrad Rzeszutek Wilk
2010-03-17 22:48 ` Alok Kataria
2010-07-20 22:14 ` Alok Kataria
2010-07-21 4:58 ` FUJITA Tomonori
2010-07-21 17:13 ` Alok Kataria
2010-07-21 23:44 ` FUJITA Tomonori
2010-07-22 0:03 ` FUJITA Tomonori
2010-07-22 18:34 ` Alok Kataria
2010-07-23 14:22 ` Konrad Rzeszutek Wilk
2010-07-23 14:33 ` Andi Kleen [this message]
2010-07-23 14:59 ` Konrad Rzeszutek Wilk
2010-07-23 15:23 ` Andi Kleen
2010-07-28 10:10 ` FUJITA Tomonori
2010-07-28 11:09 ` Andi Kleen
2010-07-28 14:20 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C49A83C.8070203@linux.intel.com \
--to=ak@linux.intel.com \
--cc=akataria@vmware.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=konrad.wilk@oracle.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petr@vmware.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.