From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Novotny Subject: Re: [PATCH] Introduce dom0-min-space configuration option Date: Mon, 26 Jul 2010 08:55:06 +0200 Message-ID: <4C4D314A.7080605@redhat.com> References: <4C3B59FE.2060201@redhat.com> <19516.43557.723062.885082@mariner.uk.xensource.com> <4C3D9E22.3030302@redhat.com> <19526.62789.227136.192517@mariner.uk.xensource.com> <4C47F857.4060606@redhat.com> <19529.48273.52500.896247@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19529.48273.52500.896247@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: "'xen-devel@lists.xensource.com'" List-Id: xen-devel@lists.xenproject.org On 07/23/2010 06:00 PM, Ian Jackson wrote: > Michal Novotny writes ("Re: [Xen-devel] [PATCH] Introduce dom0-min-space configuration option"): > >> Well, there's no other way to fix it than to implement a check for >> enough space on dom0 for extracting vmlinuz and initrd files from the >> image file. If it's partially extracted it's understandable that the >> data are not valid input for zStream processing and therefore it runs >> into Z_BUF_ERROR (-5) during the process. >> > No, it is not understandable that the system should continue to try to > execute a partially-extracted kernel. This needs to be fixed. > Well, if the kernel is extracted partially could it get decompressed well? I don't think so since there's a data stream missing. > >> Why do you think my patch is entirely wrong? >> > Because you are treating the symptoms but not addressing the cause. > > Ian. > From what I know this is caused by insufficient disk space and therefore the kernel and/or initrd are extracted just partially so there's no valid end of the input data stream. I think that making sure that the data will be extracted fully and successfully from the image file is fixing the root cause. Or do you think that we should alter the message in gunzip function to say that there's an error in data stream (premature end of data stream) and that user should check for enough space on dom0? Michal -- Michal Novotny, RHCE Virtualization Team (xen userspace), Red Hat