From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Novotny Subject: Re: [PATCH] Introduce dom0-min-space configuration option Date: Mon, 26 Jul 2010 14:48:45 +0200 Message-ID: <4C4D842D.8030100@redhat.com> References: <4C3B59FE.2060201@redhat.com> <19516.43557.723062.885082@mariner.uk.xensource.com> <4C3D9E22.3030302@redhat.com> <19526.62789.227136.192517@mariner.uk.xensource.com> <4C47F857.4060606@redhat.com> <19529.48273.52500.896247@mariner.uk.xensource.com> <4C4D314A.7080605@redhat.com> <4C4D5C7D.3030302@redhat.com> <4C4D6529.3090409@redhat.com> <4C4D6F06.6090509@redhat.com> <4C4D6FBB.6040703@redhat.com> <4C4D71FB.6020806@redhat.com> <4C4D7601.7010503@redhat.com> <4C4D7E4B.4060201@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4C4D7E4B.4060201@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Paolo Bonzini Cc: "'xen-devel@lists.xensource.com'" , Ian Jackson List-Id: xen-devel@lists.xenproject.org On 07/26/2010 02:23 PM, Paolo Bonzini wrote: > On 07/26/2010 01:48 PM, Michal Novotny wrote: >>> >> Well, the root cause is insufficient disk space since without >> insufficient disk space issue we won't be running into those issues. In >> fact there are 2 points of view on this one: >> >> 1) implement a check for enough disk space (this is what I did) >> 2) implement the proper error message saying there is not enough space >> to extract it (ENOSPC) - this is what you and Ian suggest >> >> I am not telling any of those options is bad, nevertheless it's based >> just on the point of view. So, is option 2 better and worth >> implementing rather than limiting the domain run only to case with >> enough space on dom0? > > Yes, definitely. > > Option 1 wouldn't work, initrd and kernel files have all sort of sizes. > > Paolo Ok, this way it makes sense, however when setting dom0-min-space to 100 (MiB) there's no such kernel/initrd that big but I'm not saying this is bad. Somewhat better error reporting will be the right way to go after all. Michal -- Michal Novotny, RHCE Virtualization Team (xen userspace), Red Hat