From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Keith" Subject: Re: [RFC 02/14] net: add rte prefix to arp defines Date: Wed, 24 Oct 2018 14:53:25 +0000 Message-ID: <4C4FCEA1-EA26-4053-8235-2ACADE2F107D@intel.com> References: <20181024081833.21432-1-olivier.matz@6wind.com> <20181024081833.21432-3-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: dpdk-dev To: Olivier Matz Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0E95158EC for ; Wed, 24 Oct 2018 16:53:27 +0200 (CEST) In-Reply-To: <20181024081833.21432-3-olivier.matz@6wind.com> Content-Language: en-US Content-ID: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Oct 24, 2018, at 1:18 AM, Olivier Matz wrote: >=20 > Add 'RTE_' prefix to defines: > - rename ARP_HRD_ETHER as RTE_ARP_HRD_ETHER. > - rename ARP_OP_REQUEST as RTE_ARP_OP_REQUEST. > - rename ARP_OP_REPLY as RTE_ARP_OP_REPLY. > - rename ARP_OP_REVREQUEST as RTE_ARP_OP_REVREQUEST. > - rename ARP_OP_REVREPLY as RTE_ARP_OP_REVREPLY. > - rename ARP_OP_INVREQUEST as RTE_ARP_OP_INVREQUEST. > - rename ARP_OP_INVREPLY as RTE_ARP_OP_INVREPLY. >=20 > Signed-off-by: Olivier Matz Were these conflicting with external headers ? If not it maybe reasonable to keep the old defines for a release or two and= then deprecate the old ones by defining the old defines in terms of the ne= w defines. This way we can support the old ones for a while then state they= will be deprecated later. Trying to make it easier for developers to update code. What do you think Regards, Keith