From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 15/15] KVM: x86 emulator: Decode memory operands directly
 into a 'struct operand'
Date: Mon, 02 Aug 2010 09:28:53 +0200
Message-ID: <4C5673B5.3000805@redhat.com>
References: <1280672613-14026-1-git-send-email-avi@redhat.com> <1280672613-14026-16-git-send-email-avi@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-bw0-f46.google.com ([209.85.214.46]:44308 "EHLO
	mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752555Ab0HBH25 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 2 Aug 2010 03:28:57 -0400
Received: by bwz1 with SMTP id 1so1299933bwz.19
        for <kvm@vger.kernel.org>; Mon, 02 Aug 2010 00:28:56 -0700 (PDT)
In-Reply-To: <1280672613-14026-16-git-send-email-avi@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 08/01/2010 04:23 PM, Avi Kivity wrote:
>   	if (c->src.type == OP_MEM) {
> +		if (c->d & NoAccess)
> +			goto no_fetch;
>   		rc = read_emulated(ctxt, ops, c->src.addr.mem,
>   					c->src.valptr, c->src.bytes);
>   		if (rc != X86EMUL_CONTINUE)
>   			goto done;
>   		c->src.orig_val = c->src.val;
> +	no_fetch:
> +		;
>   	}

Maybe remove the goto?

	if (c->src.type == OP_MEM && !(c->d & NoAccess)) {
		rc = read_emulated(ctxt, ops, c->src.addr.mem,
				   c->src.valptr, c->src.bytes);
		if (rc != X86EMUL_CONTINUE)
			goto done;
		c->src.orig_val = c->src.val;
	}

Or do you have other plans for it? :)

Thanks,

Paolo