From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 13/24] Implement VMREAD and VMWRITE
Date: Wed, 04 Aug 2010 19:41:41 +0300
Message-ID: <4C599845.7000702@redhat.com>
References: <1276431753-nyh@il.ibm.com> <201006131229.o5DCTDhk013030@rice.haifa.ibm.com> <4C15F802.7060106@redhat.com> <20100804160907.GC15156@fermat.math.technion.ac.il>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: "Nadav Har'El" <nyh@math.technion.ac.il>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:14111 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755263Ab0HDQlt (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 4 Aug 2010 12:41:49 -0400
In-Reply-To: <20100804160907.GC15156@fermat.math.technion.ac.il>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

  On 08/04/2010 07:09 PM, Nadav Har'El wrote:
>
>
>>> +		kvm_read_guest_virt(gva,&field_value,
>>> +			vmcs_field_size(field_type, vcpu), vcpu, NULL);
>>>
>> Check for exception.
> I am not sure what I should really do here... In emulating VMWRITE, we
> try to read from memory the pointer of where to store the result, and
> kvm_read_guest_virt fails (return !=0). What shall I do in such a case,
> queue a PF_VECTOR?

Yes indeed.  Plenty of kvm code does that (or needs to do it).

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.