All of lore.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL for 2.6.36] V4L/DVB fixes
@ 2010-08-12 18:14 Mauro Carvalho Chehab
  2010-08-24  8:45 ` [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency Ingo Molnar
  0 siblings, 1 reply; 13+ messages in thread
From: Mauro Carvalho Chehab @ 2010-08-12 18:14 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Andrew Morton, Linux Media Mailing List,
	Linux Kernel Mailing List, Randy Dunlap

Linus,

Please pull from:
  ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus

For 3 build fixes.

Cheers,
Mauro.

The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa:

  Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 10:17:19 -0700)

are available in the git repository at:

  ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus

Mauro Carvalho Chehab (2):
      V4L/DVB: Fix IR_CORE dependencies
      V4L/DVB: fix Kconfig to depends on VIDEO_IR

Randy Dunlap (1):
      V4L/DVB: v4l2-ctrls.c: needs to include slab.h

 drivers/media/IR/Kconfig            |    9 ++++++++-
 drivers/media/dvb/dm1105/Kconfig    |    2 +-
 drivers/media/dvb/dvb-usb/Kconfig   |    2 +-
 drivers/media/dvb/siano/Kconfig     |    2 +-
 drivers/media/dvb/ttpci/Kconfig     |    2 +-
 drivers/media/video/bt8xx/Kconfig   |    2 +-
 drivers/media/video/cx18/Kconfig    |    2 +-
 drivers/media/video/cx231xx/Kconfig |    2 +-
 drivers/media/video/cx23885/Kconfig |    2 +-
 drivers/media/video/cx88/Kconfig    |    2 +-
 drivers/media/video/em28xx/Kconfig  |    2 +-
 drivers/media/video/ivtv/Kconfig    |    2 +-
 drivers/media/video/saa7134/Kconfig |    2 +-
 drivers/media/video/tlg2300/Kconfig |    2 +-
 drivers/media/video/v4l2-ctrls.c    |    1 +
 15 files changed, 22 insertions(+), 14 deletions(-)


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
  2010-08-12 18:14 [GIT PULL for 2.6.36] V4L/DVB fixes Mauro Carvalho Chehab
@ 2010-08-24  8:45 ` Ingo Molnar
  2010-08-24 15:25   ` Randy Dunlap
  0 siblings, 1 reply; 13+ messages in thread
From: Ingo Molnar @ 2010-08-24  8:45 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Linus Torvalds, Andrew Morton, Linux Media Mailing List,
	Linux Kernel Mailing List, Randy Dunlap


* Mauro Carvalho Chehab <mchehab@redhat.com> wrote:

> Linus,
> 
> Please pull from:
>   ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus
> 
> For 3 build fixes.
> 
> Cheers,
> Mauro.
> 
> The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa:
> 
>   Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 10:17:19 -0700)
> 
> are available in the git repository at:
> 
>   ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus
> 
> Mauro Carvalho Chehab (2):
>       V4L/DVB: Fix IR_CORE dependencies
>       V4L/DVB: fix Kconfig to depends on VIDEO_IR
> 
> Randy Dunlap (1):
>       V4L/DVB: v4l2-ctrls.c: needs to include slab.h

FYI, there's one more IR_CORE related build bug which triggers 
frequently in randconfig tests - see the fix below.

Thanks,

	Ingo

------------------->
>From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Tue, 24 Aug 2010 10:41:33 +0200
Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency

This build bug triggers:

 drivers/built-in.o: In function `mantis_exit':
 (.text+0x377413): undefined reference to `ir_input_unregister'
 drivers/built-in.o: In function `mantis_input_init':
 (.text+0x3774ff): undefined reference to `__ir_input_register'

If MANTIS_CORE is enabled but IR_CORE is not. Add the correct
dependency.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/media/dvb/mantis/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/dvb/mantis/Kconfig b/drivers/media/dvb/mantis/Kconfig
index decdeda..fd0830e 100644
--- a/drivers/media/dvb/mantis/Kconfig
+++ b/drivers/media/dvb/mantis/Kconfig
@@ -1,6 +1,6 @@
 config MANTIS_CORE
 	tristate "Mantis/Hopper PCI bridge based devices"
-	depends on PCI && I2C && INPUT
+	depends on PCI && I2C && INPUT && IR_CORE
 
 	help
 	  Support for PCI cards based on the Mantis and Hopper PCi bridge.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
  2010-08-24  8:45 ` [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency Ingo Molnar
@ 2010-08-24 15:25   ` Randy Dunlap
  2010-08-24 19:30     ` Ingo Molnar
  0 siblings, 1 reply; 13+ messages in thread
From: Randy Dunlap @ 2010-08-24 15:25 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: Mauro Carvalho Chehab, Linus Torvalds, Andrew Morton,
	Linux Media Mailing List, Linux Kernel Mailing List

On 08/24/10 01:45, Ingo Molnar wrote:
> 
> * Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
> 
>> Linus,
>>
>> Please pull from:
>>   ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus
>>
>> For 3 build fixes.
>>
>> Cheers,
>> Mauro.
>>
>> The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa:
>>
>>   Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 10:17:19 -0700)
>>
>> are available in the git repository at:
>>
>>   ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus
>>
>> Mauro Carvalho Chehab (2):
>>       V4L/DVB: Fix IR_CORE dependencies
>>       V4L/DVB: fix Kconfig to depends on VIDEO_IR
>>
>> Randy Dunlap (1):
>>       V4L/DVB: v4l2-ctrls.c: needs to include slab.h
> 
> FYI, there's one more IR_CORE related build bug which triggers 
> frequently in randconfig tests - see the fix below.
> 
> Thanks,
> 
> 	Ingo
> 
> ------------------->
> From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001
> From: Ingo Molnar <mingo@elte.hu>
> Date: Tue, 24 Aug 2010 10:41:33 +0200
> Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
> 
> This build bug triggers:
> 
>  drivers/built-in.o: In function `mantis_exit':
>  (.text+0x377413): undefined reference to `ir_input_unregister'
>  drivers/built-in.o: In function `mantis_input_init':
>  (.text+0x3774ff): undefined reference to `__ir_input_register'
> 
> If MANTIS_CORE is enabled but IR_CORE is not. Add the correct
> dependency.
> 
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
>  drivers/media/dvb/mantis/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/dvb/mantis/Kconfig b/drivers/media/dvb/mantis/Kconfig
> index decdeda..fd0830e 100644
> --- a/drivers/media/dvb/mantis/Kconfig
> +++ b/drivers/media/dvb/mantis/Kconfig
> @@ -1,6 +1,6 @@
>  config MANTIS_CORE
>  	tristate "Mantis/Hopper PCI bridge based devices"
> -	depends on PCI && I2C && INPUT
> +	depends on PCI && I2C && INPUT && IR_CORE
>  
>  	help
>  	  Support for PCI cards based on the Mantis and Hopper PCi bridge.


Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
http://lkml.org/lkml/2010/8/17/341

thanks,
-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
  2010-08-24 15:25   ` Randy Dunlap
@ 2010-08-24 19:30     ` Ingo Molnar
  2010-08-24 21:44       ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 13+ messages in thread
From: Ingo Molnar @ 2010-08-24 19:30 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Mauro Carvalho Chehab, Linus Torvalds, Andrew Morton,
	Linux Media Mailing List, Linux Kernel Mailing List


* Randy Dunlap <randy.dunlap@oracle.com> wrote:

> On 08/24/10 01:45, Ingo Molnar wrote:
> > 
> > * Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
> > 
> >> Linus,
> >>
> >> Please pull from:
> >>   ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus
> >>
> >> For 3 build fixes.
> >>
> >> Cheers,
> >> Mauro.
> >>
> >> The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa:
> >>
> >>   Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 10:17:19 -0700)
> >>
> >> are available in the git repository at:
> >>
> >>   ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus
> >>
> >> Mauro Carvalho Chehab (2):
> >>       V4L/DVB: Fix IR_CORE dependencies
> >>       V4L/DVB: fix Kconfig to depends on VIDEO_IR
> >>
> >> Randy Dunlap (1):
> >>       V4L/DVB: v4l2-ctrls.c: needs to include slab.h
> > 
> > FYI, there's one more IR_CORE related build bug which triggers 
> > frequently in randconfig tests - see the fix below.
> > 
> > Thanks,
> > 
> > 	Ingo
> > 
> > ------------------->
> > From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001
> > From: Ingo Molnar <mingo@elte.hu>
> > Date: Tue, 24 Aug 2010 10:41:33 +0200
> > Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
> > 
> > This build bug triggers:
> > 
> >  drivers/built-in.o: In function `mantis_exit':
> >  (.text+0x377413): undefined reference to `ir_input_unregister'
> >  drivers/built-in.o: In function `mantis_input_init':
> >  (.text+0x3774ff): undefined reference to `__ir_input_register'
> > 
> > If MANTIS_CORE is enabled but IR_CORE is not. Add the correct
> > dependency.
> > 
> > Signed-off-by: Ingo Molnar <mingo@elte.hu>
> > ---
> >  drivers/media/dvb/mantis/Kconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/media/dvb/mantis/Kconfig b/drivers/media/dvb/mantis/Kconfig
> > index decdeda..fd0830e 100644
> > --- a/drivers/media/dvb/mantis/Kconfig
> > +++ b/drivers/media/dvb/mantis/Kconfig
> > @@ -1,6 +1,6 @@
> >  config MANTIS_CORE
> >  	tristate "Mantis/Hopper PCI bridge based devices"
> > -	depends on PCI && I2C && INPUT
> > +	depends on PCI && I2C && INPUT && IR_CORE
> >  
> >  	help
> >  	  Support for PCI cards based on the Mantis and Hopper PCi bridge.
> 
> 
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> http://lkml.org/lkml/2010/8/17/341

Your patch came first :-)

Btw., the reason i missed your patch is that i grepped lkml for the 
static build failure - while your changelog contained the modular one. 
Oh well :)

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
  2010-08-24 19:30     ` Ingo Molnar
@ 2010-08-24 21:44       ` Mauro Carvalho Chehab
  2010-08-26 12:34         ` Bjørn Mork
  0 siblings, 1 reply; 13+ messages in thread
From: Mauro Carvalho Chehab @ 2010-08-24 21:44 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: Randy Dunlap, Linus Torvalds, Andrew Morton,
	Linux Media Mailing List, Linux Kernel Mailing List

Em 24-08-2010 16:30, Ingo Molnar escreveu:
> 
> * Randy Dunlap <randy.dunlap@oracle.com> wrote:
> 
>> On 08/24/10 01:45, Ingo Molnar wrote:
>>>
>>> * Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
>>>
>>>> Linus,
>>>>
>>>> Please pull from:
>>>>   ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus
>>>>
>>>> For 3 build fixes.
>>>>
>>>> Cheers,
>>>> Mauro.
>>>>
>>>> The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa:
>>>>
>>>>   Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 10:17:19 -0700)
>>>>
>>>> are available in the git repository at:
>>>>
>>>>   ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus
>>>>
>>>> Mauro Carvalho Chehab (2):
>>>>       V4L/DVB: Fix IR_CORE dependencies
>>>>       V4L/DVB: fix Kconfig to depends on VIDEO_IR
>>>>
>>>> Randy Dunlap (1):
>>>>       V4L/DVB: v4l2-ctrls.c: needs to include slab.h
>>>
>>> FYI, there's one more IR_CORE related build bug which triggers 
>>> frequently in randconfig tests - see the fix below.
>>>
>>> Thanks,
>>>
>>> 	Ingo
>>>
>>> ------------------->
>>> From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001
>>> From: Ingo Molnar <mingo@elte.hu>
>>> Date: Tue, 24 Aug 2010 10:41:33 +0200
>>> Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
>>>
>>> This build bug triggers:
>>>
>>>  drivers/built-in.o: In function `mantis_exit':
>>>  (.text+0x377413): undefined reference to `ir_input_unregister'
>>>  drivers/built-in.o: In function `mantis_input_init':
>>>  (.text+0x3774ff): undefined reference to `__ir_input_register'
>>>
>>> If MANTIS_CORE is enabled but IR_CORE is not. Add the correct
>>> dependency.
>>>
>>> Signed-off-by: Ingo Molnar <mingo@elte.hu>
>>> ---
>>>  drivers/media/dvb/mantis/Kconfig |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/media/dvb/mantis/Kconfig b/drivers/media/dvb/mantis/Kconfig
>>> index decdeda..fd0830e 100644
>>> --- a/drivers/media/dvb/mantis/Kconfig
>>> +++ b/drivers/media/dvb/mantis/Kconfig
>>> @@ -1,6 +1,6 @@
>>>  config MANTIS_CORE
>>>  	tristate "Mantis/Hopper PCI bridge based devices"
>>> -	depends on PCI && I2C && INPUT
>>> +	depends on PCI && I2C && INPUT && IR_CORE
>>>  
>>>  	help
>>>  	  Support for PCI cards based on the Mantis and Hopper PCi bridge.
>>
>>
>> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
>> http://lkml.org/lkml/2010/8/17/341
> 
> Your patch came first :-)
> 
> Btw., the reason i missed your patch is that i grepped lkml for the 
> static build failure - while your changelog contained the modular one. 
> Oh well :)

I've added this patch earlier today on my tree:

http://git.linuxtv.org/media_tree.git?a=commit;h=3a057c36346f60bd0fb4fe7d7a68c4d931d8768f

and the other IR_CORE fixup at staging/tm6000:
http://git.linuxtv.org/media_tree.git?a=commit;h=926a2496438f44268130f72f5e102dcac484573d

I'll be sending them today to my linux-next tree and likely tomorrow to upstream,
together with a few other fixes.

> 
> Thanks,
> 
> 	Ingo


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
  2010-08-24 21:44       ` Mauro Carvalho Chehab
@ 2010-08-26 12:34         ` Bjørn Mork
  0 siblings, 0 replies; 13+ messages in thread
From: Bjørn Mork @ 2010-08-26 12:34 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-media

I wonder, am I really the only one who find it somewhat strange that
it's necessary to break the mantis driver by doing changes to code which
is not used at all?  Yes, mantis_input.c may be linked into mantis_core,
so it is capable of breaking the build, but there is *nothing* calling
the code.

IMHO mantis_input.c should be removed unless it can be fixed up enough
to be enabled, but one would have to know why it was disabled in the
first place to do that.  Dead code can always be ressurrected later if
someone is willing to work on it.  This completely unnecessary
dependency bug gives you at least one good reason why keeping dead code
is bad.

(Keeping the code might have been considered if it was likely to be used
in the near future, but this is not the case given that you do not
currently accept any patches actually improving the mantis driver.)

It's not that this bug is so bad or nothing.  I'm just puzzled by your
development priorities, which is the direct cause of this bug.

Let me know if you are going to start accepting patches for the mantis
driver (the best way is by doing something with the patches already
posted), and I will prepare and test a patch removing mantis_input.c

Just my €0.02


Bjørn


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [GIT PULL for 2.6.36] V4L/DVB fixes
  2010-09-28  0:36   ` Mauro Carvalho Chehab
@ 2010-09-30  9:56     ` Brian Rogers
  0 siblings, 0 replies; 13+ messages in thread
From: Brian Rogers @ 2010-09-30  9:56 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Linus Torvalds, Andrew Morton, Linux Media Mailing List,
	Linux Kernel Mailing List

  On 09/27/2010 05:36 PM, Mauro Carvalho Chehab wrote:
> I'll clean up the mess and prepare a new pull request in the next days.

Can you look at including "ir-core: Fix null dereferences in the 
protocols sysfs interface"? I never got a response to that, and it's a 
regression fix for 2.6.36.

https://patchwork.kernel.org/patch/199002/


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [GIT PULL for 2.6.36] V4L/DVB fixes
  2010-09-30  3:08     ` Mauro Carvalho Chehab
@ 2010-09-30  3:50       ` hermann pitton
  0 siblings, 0 replies; 13+ messages in thread
From: hermann pitton @ 2010-09-30  3:50 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Linus Torvalds, Andrew Morton, Linux Media Mailing List,
	Linux Kernel Mailing List


Am Donnerstag, den 30.09.2010, 00:08 -0300 schrieb Mauro Carvalho
Chehab:
> Em 29-09-2010 22:04, hermann pitton escreveu:
> > 
> > Linus,
> > 
> > Am Montag, den 27.09.2010, 17:02 -0700 schrieb Linus Torvalds:
> >> On Mon, Sep 27, 2010 at 1:57 PM, Mauro Carvalho Chehab
> >> <mchehab@redhat.com> wrote:
> >>> The following changes since commit 32163f4b2cef28a5aab8b226ffecfc6379a53786:
> >>>
> >>>  alpha: fix usp value in multithreaded coredumps (2010-09-25 14:38:13 -0700)
> >>>
> >>> are available in the git repository at:
> >>>  ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus
> >>
> >> I get
> >>
> >>   scripts/kconfig/conf --oldconfig arch/x86/Kconfig
> >>   drivers/media/Kconfig:146: 'endif' in different file than 'if'
> >>   drivers/media/IR/Kconfig:15: location of the 'if'
> >>   drivers/Kconfig:114: unexpected 'endmenu' within if block
> >>   drivers/Kconfig:1: missing end statement for this entry
> >>   make[1]: *** [oldconfig] Error 1
> >>   make: *** [oldconfig] Error 2
> >>
> >> with this. And it seems to be due to a totally broken commit at the
> >> very beginning of the series by a commit called "Kconfig fixes"
> >> (Hah!), that clearly has not been tested at all.
> >>
> >> The commit sequence was also done today, apparently immediately before
> >> sending me the pull request. Which sure as hell explains the "clearly
> >> not tested at all" situation.
> >>
> >> Don't do this. You are now officially on my shit-list for sending me
> >> total crap.
> >>
> >> How effing hard can it be to understand: you don't send me stuff that
> >> hasn't been tested. It needs to be in -next for SEVERAL DAYS, and you
> >> don't rebase it or take it from some random quilt series just before
> >> sending it to me.
> >>
> >> That's true _especially_ during the -rc series. But it's damn well
> >> true at any other time too.
> >>
> >> I'm angry. I expect at least some _minimal_ amount of competence from
> >> people I pull from. This was not it. Get your ^&#! act together!
> >>
> >>                                    Linus
> > 
> > you should not be such rude.
> > 
> > You have never been in any hardware details on v4l and dvb.
> > 
> > After Gerd Knorr did quit, out of reasons, you noticed there is some
> > noise on v4l and dvb, but you never had to fix much on your own in the
> > last eight years.
> > 
> > Shouting around and blaming others always was enough ...
> > 
> > I agree, a rc-1 should be at least compile tested.
> > 
> > Any idea, why this goes away?
> 
> Hermann,
> 
> That's OK. I did crap. Linus is right. I'll send him the patches again
> after having the same tree branch being tested for a few days at linux-next, 
> without any bad results.
> 
> Cheers,
> Mauro.

Mauro,

hopefully, a few days on linux-next can replace all what we had in the
past, causing sometimes years of delay ...

What to say ?

OK, if you say we are fine with it now, it is up to you.

So, the whole mistake was, that Linus did not start kicking asses harder
earlier?

What a total crap!

Cheers,
Hermann







^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [GIT PULL for 2.6.36] V4L/DVB fixes
  2010-09-30  1:04   ` hermann pitton
@ 2010-09-30  3:08     ` Mauro Carvalho Chehab
  2010-09-30  3:50       ` hermann pitton
  0 siblings, 1 reply; 13+ messages in thread
From: Mauro Carvalho Chehab @ 2010-09-30  3:08 UTC (permalink / raw)
  To: hermann pitton
  Cc: Linus Torvalds, Andrew Morton, Linux Media Mailing List,
	Linux Kernel Mailing List

Em 29-09-2010 22:04, hermann pitton escreveu:
> 
> Linus,
> 
> Am Montag, den 27.09.2010, 17:02 -0700 schrieb Linus Torvalds:
>> On Mon, Sep 27, 2010 at 1:57 PM, Mauro Carvalho Chehab
>> <mchehab@redhat.com> wrote:
>>> The following changes since commit 32163f4b2cef28a5aab8b226ffecfc6379a53786:
>>>
>>>  alpha: fix usp value in multithreaded coredumps (2010-09-25 14:38:13 -0700)
>>>
>>> are available in the git repository at:
>>>  ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus
>>
>> I get
>>
>>   scripts/kconfig/conf --oldconfig arch/x86/Kconfig
>>   drivers/media/Kconfig:146: 'endif' in different file than 'if'
>>   drivers/media/IR/Kconfig:15: location of the 'if'
>>   drivers/Kconfig:114: unexpected 'endmenu' within if block
>>   drivers/Kconfig:1: missing end statement for this entry
>>   make[1]: *** [oldconfig] Error 1
>>   make: *** [oldconfig] Error 2
>>
>> with this. And it seems to be due to a totally broken commit at the
>> very beginning of the series by a commit called "Kconfig fixes"
>> (Hah!), that clearly has not been tested at all.
>>
>> The commit sequence was also done today, apparently immediately before
>> sending me the pull request. Which sure as hell explains the "clearly
>> not tested at all" situation.
>>
>> Don't do this. You are now officially on my shit-list for sending me
>> total crap.
>>
>> How effing hard can it be to understand: you don't send me stuff that
>> hasn't been tested. It needs to be in -next for SEVERAL DAYS, and you
>> don't rebase it or take it from some random quilt series just before
>> sending it to me.
>>
>> That's true _especially_ during the -rc series. But it's damn well
>> true at any other time too.
>>
>> I'm angry. I expect at least some _minimal_ amount of competence from
>> people I pull from. This was not it. Get your ^&#! act together!
>>
>>                                    Linus
> 
> you should not be such rude.
> 
> You have never been in any hardware details on v4l and dvb.
> 
> After Gerd Knorr did quit, out of reasons, you noticed there is some
> noise on v4l and dvb, but you never had to fix much on your own in the
> last eight years.
> 
> Shouting around and blaming others always was enough ...
> 
> I agree, a rc-1 should be at least compile tested.
> 
> Any idea, why this goes away?

Hermann,

That's OK. I did crap. Linus is right. I'll send him the patches again
after having the same tree branch being tested for a few days at linux-next, 
without any bad results.

Cheers,
Mauro.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [GIT PULL for 2.6.36] V4L/DVB fixes
  2010-09-28  0:02 ` Linus Torvalds
  2010-09-28  0:36   ` Mauro Carvalho Chehab
@ 2010-09-30  1:04   ` hermann pitton
  2010-09-30  3:08     ` Mauro Carvalho Chehab
  1 sibling, 1 reply; 13+ messages in thread
From: hermann pitton @ 2010-09-30  1:04 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Mauro Carvalho Chehab, Andrew Morton, Linux Media Mailing List,
	Linux Kernel Mailing List


Linus,

Am Montag, den 27.09.2010, 17:02 -0700 schrieb Linus Torvalds:
> On Mon, Sep 27, 2010 at 1:57 PM, Mauro Carvalho Chehab
> <mchehab@redhat.com> wrote:
> > The following changes since commit 32163f4b2cef28a5aab8b226ffecfc6379a53786:
> >
> >  alpha: fix usp value in multithreaded coredumps (2010-09-25 14:38:13 -0700)
> >
> > are available in the git repository at:
> >  ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus
> 
> I get
> 
>   scripts/kconfig/conf --oldconfig arch/x86/Kconfig
>   drivers/media/Kconfig:146: 'endif' in different file than 'if'
>   drivers/media/IR/Kconfig:15: location of the 'if'
>   drivers/Kconfig:114: unexpected 'endmenu' within if block
>   drivers/Kconfig:1: missing end statement for this entry
>   make[1]: *** [oldconfig] Error 1
>   make: *** [oldconfig] Error 2
> 
> with this. And it seems to be due to a totally broken commit at the
> very beginning of the series by a commit called "Kconfig fixes"
> (Hah!), that clearly has not been tested at all.
> 
> The commit sequence was also done today, apparently immediately before
> sending me the pull request. Which sure as hell explains the "clearly
> not tested at all" situation.
> 
> Don't do this. You are now officially on my shit-list for sending me
> total crap.
> 
> How effing hard can it be to understand: you don't send me stuff that
> hasn't been tested. It needs to be in -next for SEVERAL DAYS, and you
> don't rebase it or take it from some random quilt series just before
> sending it to me.
> 
> That's true _especially_ during the -rc series. But it's damn well
> true at any other time too.
> 
> I'm angry. I expect at least some _minimal_ amount of competence from
> people I pull from. This was not it. Get your ^&#! act together!
> 
>                                    Linus

you should not be such rude.

You have never been in any hardware details on v4l and dvb.

After Gerd Knorr did quit, out of reasons, you noticed there is some
noise on v4l and dvb, but you never had to fix much on your own in the
last eight years.

Shouting around and blaming others always was enough ...

I agree, a rc-1 should be at least compile tested.

Any idea, why this goes away?

Cheers,
Hermann











^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [GIT PULL for 2.6.36] V4L/DVB fixes
  2010-09-28  0:02 ` Linus Torvalds
@ 2010-09-28  0:36   ` Mauro Carvalho Chehab
  2010-09-30  9:56     ` Brian Rogers
  2010-09-30  1:04   ` hermann pitton
  1 sibling, 1 reply; 13+ messages in thread
From: Mauro Carvalho Chehab @ 2010-09-28  0:36 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Andrew Morton, Linux Media Mailing List, Linux Kernel Mailing List

Em 27-09-2010 21:02, Linus Torvalds escreveu:
> On Mon, Sep 27, 2010 at 1:57 PM, Mauro Carvalho Chehab
> <mchehab@redhat.com> wrote:
>> The following changes since commit 32163f4b2cef28a5aab8b226ffecfc6379a53786:
>>
>>  alpha: fix usp value in multithreaded coredumps (2010-09-25 14:38:13 -0700)
>>
>> are available in the git repository at:
>>  ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus
> 
> I get
> 
>   scripts/kconfig/conf --oldconfig arch/x86/Kconfig
>   drivers/media/Kconfig:146: 'endif' in different file than 'if'
>   drivers/media/IR/Kconfig:15: location of the 'if'
>   drivers/Kconfig:114: unexpected 'endmenu' within if block
>   drivers/Kconfig:1: missing end statement for this entry
>   make[1]: *** [oldconfig] Error 1
>   make: *** [oldconfig] Error 2
> 
> with this. And it seems to be due to a totally broken commit at the
> very beginning of the series by a commit called "Kconfig fixes"
> (Hah!), that clearly has not been tested at all.

Argh! something got completely wrong here. Sorry for the mess.
This patch is already upstream (changeset ade321c5b8a0e4).

I had some troubles on my local tree (some objects missed after a gc on
a shared repository). I had to recover my local tree, to avoid loosing 
some patches applied there for linux-next. It seems that I did a bad work 
on recovering them. I always compile everything a few times before sending, 
but this time, I just didn't notice.

> The commit sequence was also done today, apparently immediately before
> sending me the pull request. Which sure as hell explains the "clearly
> not tested at all" situation.
> 
> Don't do this. You are now officially on my shit-list for sending me
> total crap.
> 
> How effing hard can it be to understand: you don't send me stuff that
> hasn't been tested. It needs to be in -next for SEVERAL DAYS, and you
> don't rebase it or take it from some random quilt series just before
> sending it to me.
> 
> That's true _especially_ during the -rc series. But it's damn well
> true at any other time too.
> 
> I'm angry. I expect at least some _minimal_ amount of competence from
> people I pull from. This was not it. Get your ^&#! act together!
> 
>                                    Linus

I'll clean up the mess and prepare a new pull request in the next days.

Sorry,
Mauro.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [GIT PULL for 2.6.36] V4L/DVB fixes
  2010-09-27 20:57 [GIT PULL for 2.6.36] V4L/DVB fixes Mauro Carvalho Chehab
@ 2010-09-28  0:02 ` Linus Torvalds
  2010-09-28  0:36   ` Mauro Carvalho Chehab
  2010-09-30  1:04   ` hermann pitton
  0 siblings, 2 replies; 13+ messages in thread
From: Linus Torvalds @ 2010-09-28  0:02 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Andrew Morton, Linux Media Mailing List, Linux Kernel Mailing List

On Mon, Sep 27, 2010 at 1:57 PM, Mauro Carvalho Chehab
<mchehab@redhat.com> wrote:
> The following changes since commit 32163f4b2cef28a5aab8b226ffecfc6379a53786:
>
>  alpha: fix usp value in multithreaded coredumps (2010-09-25 14:38:13 -0700)
>
> are available in the git repository at:
>  ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus

I get

  scripts/kconfig/conf --oldconfig arch/x86/Kconfig
  drivers/media/Kconfig:146: 'endif' in different file than 'if'
  drivers/media/IR/Kconfig:15: location of the 'if'
  drivers/Kconfig:114: unexpected 'endmenu' within if block
  drivers/Kconfig:1: missing end statement for this entry
  make[1]: *** [oldconfig] Error 1
  make: *** [oldconfig] Error 2

with this. And it seems to be due to a totally broken commit at the
very beginning of the series by a commit called "Kconfig fixes"
(Hah!), that clearly has not been tested at all.

The commit sequence was also done today, apparently immediately before
sending me the pull request. Which sure as hell explains the "clearly
not tested at all" situation.

Don't do this. You are now officially on my shit-list for sending me
total crap.

How effing hard can it be to understand: you don't send me stuff that
hasn't been tested. It needs to be in -next for SEVERAL DAYS, and you
don't rebase it or take it from some random quilt series just before
sending it to me.

That's true _especially_ during the -rc series. But it's damn well
true at any other time too.

I'm angry. I expect at least some _minimal_ amount of competence from
people I pull from. This was not it. Get your ^&#! act together!

                                   Linus

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [GIT PULL for 2.6.36] V4L/DVB fixes
@ 2010-09-27 20:57 Mauro Carvalho Chehab
  2010-09-28  0:02 ` Linus Torvalds
  0 siblings, 1 reply; 13+ messages in thread
From: Mauro Carvalho Chehab @ 2010-09-27 20:57 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Andrew Morton, Linux Media Mailing List, Linux Kernel Mailing List

The following changes since commit 32163f4b2cef28a5aab8b226ffecfc6379a53786:

  alpha: fix usp value in multithreaded coredumps (2010-09-25 14:38:13 -0700)

are available in the git repository at:
  ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus

Andy Walls (1):
      V4L/DVB: cx25840: Fix typo in volume control initialization: 65335 vs. 65535

Baruch Siach (1):
      V4L/DVB: mx2_camera: fix a race causing NULL dereference

Dan Carpenter (5):
      V4L/DVB: unlock on error path
      V4L/DVB: IR: ir-raw-event: null pointer dereference
      V4L/DVB: opera1: remove unneeded NULL check
      V4L/DVB: pvrusb2: remove unneeded NULL checks
      V4L/DVB: saa7164: move dereference under NULL check

Dan Rosenberg (1):
      V4L/DVB: ivtvfb: prevent reading uninitialized stack memory

Dmitri Belimov (1):
      V4L/DVB: Fix regression for BeholdTV Columbus

Hans Verkuil (2):
      V4L/DVB: ivtv: convert gpio subdev to new control framework
      V4L/DVB: videobuf-dma-sg: set correct size in last sg element

Ionut Gabriel Popescu (1):
      V4L/DVB: mt9v022.c: Fixed compilation warning

Jarod Wilson (1):
      V4L/DVB: mceusb: add two new ASUS device IDs

Jason Wang (1):
      V4L/DVB: gspca - main: Fix a crash of some webcams on ARM arch

Jean-François Moine (1):
      V4L/DVB: gspca - sn9c20x: Bad transfer size of Bayer images

Laurent Pinchart (3):
      V4L/DVB: uvcvideo: Add support for Miricle 307K thermal webcam
      V4L/DVB: uvcvideo: Fix support for Medion Akoya All-in-one PC integrated webcam
      V4L/DVB: uvcvideo: Restrict frame rates for Chicony CNF7129 webcam

Mauro Carvalho Chehab (3):
      V4L/DVB: Don't identify PV SBTVD Hybrid as a DibCom device
      V4L/DVB: rc-core: increase repeat time
      V4L/DVB: cx231xx: Avoid an OOPS when card is unknown (card=0)

Maxim Levitsky (4):
      V4L/DVB: IR: Kconfig fixes
      V4L/DVB: IR: fix duty cycle capability
      V4L/DVB: IR: fix keys beeing stuck down forever
      V4L/DVB: IR: extend MCE keymap

Michael Grzeschik (2):
      V4L/DVB: mt9m111: cropcap and s_crop check if type is VIDEO_CAPTURE
      V4L/DVB: mt9m111: added current colorspace at g_fmt

Olivier Grenie (2):
      V4L/DVB: dib7770: enable the current mirror
      V4L/DVB: dib7000p: add disable sample and hold, and diversity delay parameter

Pawel Osciak (2):
      V4L/DVB: v4l: mem2mem_testdev: fix errorenous comparison
      V4L/DVB: v4l: mem2mem_testdev: add missing release for video_device

Randy Dunlap (1):
      V4L/DVB: tm6000: depends on IR_CORE

Richard Zidlicky (1):
      V4L/DVB: dvb: fix smscore_getbuffer() logic

Stefan Ringel (1):
      V4L/DVB: tm6000: bugfix data handling

lawrence rust (1):
      V4L/DVB: cx88: Kconfig: Remove EXPERIMENTAL dependency from VIDEO_CX88_ALSA

 drivers/media/IR/Kconfig                     |    2 +
 drivers/media/IR/ir-keytable.c               |    9 +++-
 drivers/media/IR/ir-lirc-codec.c             |    2 +-
 drivers/media/IR/ir-raw-event.c              |    4 +-
 drivers/media/IR/keymaps/rc-rc6-mce.c        |    3 +
 drivers/media/IR/mceusb.c                    |    4 ++
 drivers/media/dvb/dvb-usb/dib0700_core.c     |    3 -
 drivers/media/dvb/dvb-usb/dib0700_devices.c  |   56 +++++++++++++++++++++++-
 drivers/media/dvb/dvb-usb/opera1.c           |    4 +-
 drivers/media/dvb/frontends/dib7000p.c       |    8 +++-
 drivers/media/dvb/frontends/dib7000p.h       |    5 ++
 drivers/media/dvb/siano/smscoreapi.c         |   31 +++++--------
 drivers/media/video/cx231xx/Makefile         |    1 +
 drivers/media/video/cx231xx/cx231xx-cards.c  |   17 +++++---
 drivers/media/video/cx25840/cx25840-core.c   |    2 +-
 drivers/media/video/cx88/Kconfig             |    2 +-
 drivers/media/video/gspca/gspca.c            |    1 +
 drivers/media/video/gspca/sn9c20x.c          |    3 +-
 drivers/media/video/ivtv/ivtv-driver.c       |    1 +
 drivers/media/video/ivtv/ivtv-driver.h       |    1 +
 drivers/media/video/ivtv/ivtvfb.c            |    2 +
 drivers/media/video/mem2mem_testdev.c        |    3 +-
 drivers/media/video/mt9m111.c                |    8 +++-
 drivers/media/video/mt9v022.c                |    3 -
 drivers/media/video/mx2_camera.c             |    4 ++
 drivers/media/video/pvrusb2/pvrusb2-ctrl.c   |    6 +-
 drivers/media/video/s5p-fimc/fimc-core.c     |    3 +-
 drivers/media/video/saa7134/saa7134-cards.c  |   10 ++--
 drivers/media/video/saa7164/saa7164-buffer.c |    5 +-
 drivers/media/video/uvc/uvc_driver.c         |   33 ++++++++++++++
 drivers/media/video/uvc/uvcvideo.h           |    1 +
 drivers/media/video/videobuf-dma-sg.c        |   11 +++--
 drivers/staging/tm6000/Kconfig               |    2 +-
 drivers/staging/tm6000/tm6000-input.c        |   61 ++++++++++++++++---------
 include/media/videobuf-dma-sg.h              |    1 +
 35 files changed, 228 insertions(+), 84 deletions(-)


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2010-09-30  9:56 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-12 18:14 [GIT PULL for 2.6.36] V4L/DVB fixes Mauro Carvalho Chehab
2010-08-24  8:45 ` [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency Ingo Molnar
2010-08-24 15:25   ` Randy Dunlap
2010-08-24 19:30     ` Ingo Molnar
2010-08-24 21:44       ` Mauro Carvalho Chehab
2010-08-26 12:34         ` Bjørn Mork
2010-09-27 20:57 [GIT PULL for 2.6.36] V4L/DVB fixes Mauro Carvalho Chehab
2010-09-28  0:02 ` Linus Torvalds
2010-09-28  0:36   ` Mauro Carvalho Chehab
2010-09-30  9:56     ` Brian Rogers
2010-09-30  1:04   ` hermann pitton
2010-09-30  3:08     ` Mauro Carvalho Chehab
2010-09-30  3:50       ` hermann pitton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.