All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: Tim Deegan <Tim.Deegan@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [RFC][PATCH] walking the page lists needs the page_alloc lock
Date: Fri, 13 Aug 2010 07:40:23 +0100	[thread overview]
Message-ID: <4C6504F7020000780000FA8C@vpn.id2.novell.com> (raw)
In-Reply-To: <20100812163712.GA20252@whitby.uk.xensource.com>

>>> On 12.08.10 at 18:37, Tim Deegan <Tim.Deegan@citrix.com> wrote:
> At 16:09 +0100 on 12 Aug (1281629364), Jan Beulich wrote:
>> >>> On 23.07.10 at 15:49, Tim Deegan <Tim.Deegan@citrix.com> wrote:
>> > There are a few places in Xen where we walk a domain's page lists
>> > without holding the page_alloc lock.  They race with updates to the page
>> > lists, which are normally rare but can be quite common under PoD when
>> > the domain is close to its memory limit and the PoD reclaimer is busy.
>> > This patch protects those places by taking the page_alloc lock.
>> > 
>> > I think this is OK for the two debug-key printouts - they don't run from
>> > irq context and look deadlock-free.  The tboot change seems safe too
>> 
>> While the comment says the patch would leave debug key printouts
>> alone, ...
> 
> Sorry, my intention was to say that changes to the debug-key printouts
> are safe, not that they didn't require changes.  
> 
> The debug-key printouts (in particular the NUMA one) are where I
> actually hit this bug on a running system.

But then, to avoid a hanging system, these should be trylock-s
rather than plain locks, shouldn't they?

Jan

  reply	other threads:[~2010-08-13  6:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-23 13:49 [RFC][PATCH] walking the page lists needs the page_alloc lock Tim Deegan
2010-07-23 13:55 ` Tim Deegan
2010-08-12 15:09 ` Jan Beulich
2010-08-12 16:37   ` Tim Deegan
2010-08-13  6:40     ` Jan Beulich [this message]
2010-08-13  6:46       ` Keir Fraser
2010-08-13  7:06         ` Jan Beulich
2010-08-13  7:10           ` Keir Fraser
2010-08-13  7:20             ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C6504F7020000780000FA8C@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=Tim.Deegan@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.