From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rogan Dawes <rogan@dawes.za.net>
Date: Fri, 13 Aug 2010 15:50:34 +0200
Subject: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug
	printout	macros
In-Reply-To: <4C654B30.9060106@mvista.com>
References: <1281617086-21220-1-git-send-email-vkuzmichev@mvista.com>	<1281704276-29115-1-git-send-email-vkuzmichev@mvista.com>	<4C6542A3.5040009@dawes.za.net>	<4C6544B9.3000503@mvista.com>
	<4C6548FE.4020902@denx.de> <4C654B30.9060106@mvista.com>
Message-ID: <4C654DAA.9010701@dawes.za.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 2010/08/13 3:40 PM, Vitaly Kuzmichev wrote:
> Hi Stefano,
>
> Stefano Babic wrote:
>> If you want to remember how to set the debug output, it should be enough
>> to add a comments with "to enable the debugging, define DEBUG before
>> common.h" or something like that. I vote to remove only the two lines...
>
> Would not it be better to make one of the following?
> 1)
> #if 0
> #define DEBUG
> #endif
>
> 2)
> #ifdef CONFIG_USB_ETH_DEBUG
> #define DEBUG
> #endif

Personally, I like option 2, as it means that I have less need to touch 
general code when trying to debug my board.

I can just define that in my board config. Although, that could lead to 
a proliferation of *_DEBUG defines, which may or may not be documented.

Perhaps without the CONFIG_ part, and people who are trying to debug 
their boards need to read the code anyway to determine what debugging 
can be enabled?

Rogan