From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35607 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OjzRS-00031g-9l for qemu-devel@nongnu.org; Fri, 13 Aug 2010 14:57:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OjzRD-0002qf-4h for qemu-devel@nongnu.org; Fri, 13 Aug 2010 14:57:08 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:35615) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OjzRD-0002qY-1U for qemu-devel@nongnu.org; Fri, 13 Aug 2010 14:57:07 -0400 Received: by ywt2 with SMTP id 2so1156657ywt.4 for ; Fri, 13 Aug 2010 11:57:06 -0700 (PDT) Message-ID: <4C65957A.3060107@codemonkey.ws> Date: Fri, 13 Aug 2010 13:56:58 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1281622202-3453-14-git-send-email-stefano.stabellini@eu.citrix.com> In-Reply-To: <1281622202-3453-14-git-send-email-stefano.stabellini@eu.citrix.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 14/15] xen: destroy the VM when shutdown is requested List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stefano.stabellini@eu.citrix.com Cc: Anthony.Perard@citrix.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org On 08/12/2010 09:10 AM, stefano.stabellini@eu.citrix.com wrote: > From: Anthony PERARD > > Handle shutdown and reset requests in helper.c. > > Signed-off-by: Anthony PERARD > Signed-off-by: Stefano Stabellini > --- > target-xen/helper.c | 17 +++++++++++++++++ > 1 files changed, 17 insertions(+), 0 deletions(-) > > diff --git a/target-xen/helper.c b/target-xen/helper.c > index 4571ac0..16e628c 100644 > --- a/target-xen/helper.c > +++ b/target-xen/helper.c > @@ -397,6 +397,23 @@ static void cpu_handle_ioreq(void *opaque) > > xen_wmb(); /* Update ioreq contents /then/ update state. */ > > + /* > + * We do this before we send the response so that the tools > + * have the opportunity to pick up on the reset before the > + * guest resumes and does a hlt with interrupts disabled which > + * causes Xen to powerdown the domain. > + */ > + if (vm_running) { > + if (qemu_shutdown_requested_get()) { > + fprintf(stderr, "shutdown requested in cpu_handle_ioreq\n"); > + destroy_hvm_domain(); > + } > The patches should not introduce fprintfs in expected paths. Regards, Anthony Liguori > + if (qemu_reset_requested_get()) { > + fprintf(stderr, "reset requested in cpu_handle_ioreq.\n"); > + qemu_system_reset(); > + } > + } > + > req->state = STATE_IORESP_READY; > xc_evtchn_notify(xce_handle, ioreq_local_port[send_vcpu]); > } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 14/15] xen: destroy the VM when shutdown is requested Date: Fri, 13 Aug 2010 13:56:58 -0500 Message-ID: <4C65957A.3060107@codemonkey.ws> References: <1281622202-3453-14-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1281622202-3453-14-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: stefano.stabellini@eu.citrix.com Cc: Anthony.Perard@citrix.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org On 08/12/2010 09:10 AM, stefano.stabellini@eu.citrix.com wrote: > From: Anthony PERARD > > Handle shutdown and reset requests in helper.c. > > Signed-off-by: Anthony PERARD > Signed-off-by: Stefano Stabellini > --- > target-xen/helper.c | 17 +++++++++++++++++ > 1 files changed, 17 insertions(+), 0 deletions(-) > > diff --git a/target-xen/helper.c b/target-xen/helper.c > index 4571ac0..16e628c 100644 > --- a/target-xen/helper.c > +++ b/target-xen/helper.c > @@ -397,6 +397,23 @@ static void cpu_handle_ioreq(void *opaque) > > xen_wmb(); /* Update ioreq contents /then/ update state. */ > > + /* > + * We do this before we send the response so that the tools > + * have the opportunity to pick up on the reset before the > + * guest resumes and does a hlt with interrupts disabled which > + * causes Xen to powerdown the domain. > + */ > + if (vm_running) { > + if (qemu_shutdown_requested_get()) { > + fprintf(stderr, "shutdown requested in cpu_handle_ioreq\n"); > + destroy_hvm_domain(); > + } > The patches should not introduce fprintfs in expected paths. Regards, Anthony Liguori > + if (qemu_reset_requested_get()) { > + fprintf(stderr, "reset requested in cpu_handle_ioreq.\n"); > + qemu_system_reset(); > + } > + } > + > req->state = STATE_IORESP_READY; > xc_evtchn_notify(xce_handle, ioreq_local_port[send_vcpu]); > } >