All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: akataria@vmware.com
Cc: the arch/x86 maintainers <x86@kernel.org>,
	Greg KH <gregkh@suse.de>,
	greg@kroah.com, ksrinivasan@novell.com,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Patch] Skip cpu_calibrate for kernel running under hypervisors.
Date: Mon, 16 Aug 2010 16:56:31 -0700	[thread overview]
Message-ID: <4C69D02F.6090601@zytor.com> (raw)
In-Reply-To: <1281986754.23253.32.camel@ank32.eng.vmware.com>

On 08/16/2010 12:25 PM, Alok Kataria wrote:
> Hi, 
> 
> This is a trivial change to fix the cpu_khz value returned when running
> on a virtualized environment. We have seen instances when the cpu_khz
> value is off by couple of MHz's when running on VMware's platform on AMD
> hardware.
> 
> --
> Since the TSC frequency read from hypervisor is accurate for the guest, and
> since the hypervisor will always clock the vcpu at the TSC frequency, there is
> no need to calibrate it again. To avoid any calibration errors through
> calibrate_cpu this patch skips calling calibrate_cpu for kernel running
> under hypervisors.
> 

I'm somewhat reluctant to take this one, since it assumes all the
hypervisors act the same.  This seems rather inherently wrong.  In fact,
the whole statement is fishy as heck... instead of being dependent on
AMD and so on, this should either be a function pointer or a CPU
(mis)feature bit.

Can we do this saner?

	-hpa

  reply	other threads:[~2010-08-16 23:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-16 19:25 [Patch] Skip cpu_calibrate for kernel running under hypervisors Alok Kataria
2010-08-16 23:56 ` H. Peter Anvin [this message]
2010-08-17  5:51   ` Alok Kataria
2010-08-17  6:30     ` H. Peter Anvin
2010-08-17  7:05       ` Borislav Petkov
2010-08-17 16:45         ` Alok Kataria
2010-08-17 18:56           ` Borislav Petkov
2010-08-18 16:16             ` [PATCH] x86, tsc: Limit CPU frequency calibration on AMD Borislav Petkov
2010-08-18 16:23               ` H. Peter Anvin
2010-08-18 17:34                 ` Borislav Petkov
2010-08-18 17:44                   ` H. Peter Anvin
2010-08-18 17:51                   ` Alok Kataria
2010-08-18 18:45                     ` Borislav Petkov
2010-08-24 15:53                       ` [PATCH -v2] " Borislav Petkov
2010-08-24 17:51                         ` Alok Kataria
2010-08-24 22:33                         ` H. Peter Anvin
2010-08-25  7:06                           ` Borislav Petkov
2010-08-25 13:04                             ` Andreas Herrmann
2010-08-25 13:39                               ` Andreas Herrmann
2010-08-25 16:28                               ` [PATCH -v3] x86, tsc: Remove " Borislav Petkov
2010-08-25 21:36                                 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-08-25 22:33                                 ` [PATCH -v3] " Alok Kataria
2010-08-26  7:19                                   ` Borislav Petkov
2010-08-19 18:47               ` [PATCH] x86, tsc: Limit " john stultz
2010-08-19 20:29                 ` Borislav Petkov
2010-08-19 20:52                   ` john stultz
2010-08-17 16:48       ` [Patch] Skip cpu_calibrate for kernel running under hypervisors Alok Kataria
2010-08-17 16:49         ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C69D02F.6090601@zytor.com \
    --to=hpa@zytor.com \
    --cc=akataria@vmware.com \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=ksrinivasan@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.