From: Gernot Hoyler <Gernot.Hoyler@spansion.com>
To: linux-mtd@lists.infradead.org
Subject: Re: Re: [PATCH] mtd/nand: Spansion S30MLxxxP support
Date: Wed, 18 Aug 2010 15:03:10 +0200 [thread overview]
Message-ID: <4C6BDA0E.2080404@spansion.com> (raw)
In-Reply-To: <1281652958-2354-1-git-send-email-norris@broadcom.com>
> Note that I am unsure about the wraparound nature of the ID string
> here. I have not been able to fully test this with the physical chip.
> Essentially, the rule is correct, but the ID string detection may fail
> here. Let me know if anyone can fix this.
I have just tested this on a physical device (S30ML512P30TFE51).
Unfortunately, the extended device IDs are a little bit different so
the patch does not work yet. With a S30ML512P30TFE51, the device IDs
are as follows:
id_data[0]=0x01
id_data[1]=0x56
id_data[2]=0x00
id_data[3]=0x01
id_data[4]=0x10
id_data[5]=0x00
id_data[6]=0x00
id_data[7]=0x00
My suggestion would be to check the page size instead of the extended
IDs (seems like the patch applies to all Spansion S30ML devices with
small pages, i.e. 512 bytes). So you might write:
+ if (*maf_id == NAND_MFR_AMD && type->pagesize == 512) {
...
This works for me.
next prev parent reply other threads:[~2010-08-18 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 22:42 [PATCH] mtd/nand: Spansion S30MLxxxP support Brian Norris
2010-08-18 13:03 ` Gernot Hoyler [this message]
2010-08-19 15:11 ` [PATCH v2] " Brian Norris
2010-08-30 7:56 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6BDA0E.2080404@spansion.com \
--to=gernot.hoyler@spansion.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.