From: "Brian Norris" <norris@broadcom.com>
To: "David Woodhouse" <dwmw2@infradead.org>
Cc: "r64343@freescale.com" <r64343@freescale.com>,
Kevin Cernekee <cernekee@gmail.com>,
Tilman Sauerbeck <tilman@code-monkey.de>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: Bad assumption about ID field definition for Samsung NAND?
Date: Fri, 20 Aug 2010 14:01:47 -0700 [thread overview]
Message-ID: <4C6EED3B.4000001@broadcom.com> (raw)
In-Reply-To: <1282334008.25239.91.camel@localhost>
> Can I have a signed-off-by for it?
I don't know what's "legal" here. I'm appending the patch with a
sign-off for me and Tilman (since Tilman authored it). Hopefully that's
ok.
> Brian, I have a distinct impression that there's at least one more patch
> from you that I really ought to be sending to Linus for 2.6.36, but I
> can't find it right now. Other than this and what's already in
> mtd-2.6.git, is there anything else?
I'm really no expert on how inclusion for different versions goes; I
just send 'em to you! Anyway, this patch is *very* important:
* [PATCH] mtd: nand: Fix regression in BBM detection
http://lists.infradead.org/pipermail/linux-mtd/2010-August/031594.html
It addresses issues I overlooked with a lot of Hynix small-page NAND
(and others).
Other patches - they are ready, but not as important:
* Spansion ORNAND
http://lists.infradead.org/pipermail/linux-mtd/2010-August/031603.html
* New Samsung MLC OOB sizes
http://lists.infradead.org/pipermail/linux-mtd/2010-August/031621.html
No one has decided between these two (it's a "choose one or the other"
situation). They may or may not be ready:
mtd: nand: Expand nand_ecc_layout, deprecate ioctl ECCGETLAYOUT
Cover page: http://lists.infradead.org/pipermail/linux-mtd/2010-August/031591.html
Choice 1: http://lists.infradead.org/pipermail/linux-mtd/2010-August/031593.html
Choice 2: http://lists.infradead.org/pipermail/linux-mtd/2010-August/031598.html
Explanation: http://lists.infradead.org/pipermail/linux-mtd/2010-August/031619.html
And since you asked, the trivial...
Indentation errors :)
http://lists.infradead.org/pipermail/linux-mtd/2010-August/031588.html
You already got this one, I believe:
Fixing a typo in on a buswidth option
http://lists.infradead.org/pipermail/linux-mtd/2010-August/031518.html
Thanks for looking out for me :)
Brian
----------------------------------------------------------------
Apparently, the check for a 6-byte ID string is NOT sufficient to
determine whether or not a Samsung chip uses their new MLC detection
scheme or the old, standard scheme. This adds a condition to check cell
type.
Signed-off-by: Tilman Sauerbeck <tilman@code-monkey.de>
Signed-off-by: Brian Norris <norris@broadcom.com>
---
drivers/mtd/nand/nand_base.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index a3c7473..172a299 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2866,6 +2866,7 @@ static struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd,
*/
if (id_data[0] == id_data[6] && id_data[1] == id_data[7] &&
id_data[0] == NAND_MFR_SAMSUNG &&
+ (chip->cellinfo & NAND_CI_CELLTYPE_MSK) &&
id_data[5] != 0x00) {
/* Calc pagesize */
mtd->writesize = 2048 << (extid & 0x03);
--
1.7.0.4
next prev parent reply other threads:[~2010-08-20 21:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 18:05 Bad assumption about ID field definition for Samsung NAND? Tilman Sauerbeck
2010-08-18 23:25 ` Brian Norris
2010-08-19 17:16 ` Tilman Sauerbeck
2010-08-19 19:46 ` Kevin Cernekee
2010-08-19 22:28 ` Brian Norris
2010-08-20 3:29 ` Kevin Cernekee
2010-08-20 5:38 ` Liu Hui-R64343
2010-08-20 13:43 ` Tilman Sauerbeck
2010-08-20 17:42 ` Brian Norris
2010-08-20 19:53 ` David Woodhouse
2010-08-20 20:51 ` Tilman Sauerbeck
2010-08-20 21:01 ` Brian Norris [this message]
2010-08-20 21:34 ` David Woodhouse
2010-08-20 22:05 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6EED3B.4000001@broadcom.com \
--to=norris@broadcom.com \
--cc=cernekee@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=r64343@freescale.com \
--cc=tilman@code-monkey.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.