From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58311 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnGxG-00016i-Ud for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:15:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OnGxF-0008BX-OY for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:15:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9110) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnGxF-0008BQ-GE for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:15:45 -0400 Message-ID: <4C71856B.2050109@redhat.com> Date: Sun, 22 Aug 2010 23:15:39 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments References: <4C6A4291.1020105@redhat.com> <4C6A8CD8.2080701@codemonkey.ws> <4C6A94D0.2090201@redhat.com> <4C6D3260.8010103@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Jes Sorensen , Miguel Di Ciurcio Filho , qemu-devel On 08/19/2010 09:29 PM, Blue Swirl wrote: > >> Just to be sure I follow, are you suggesting we relax all of the bracing >> rule, or just the part about braces around single line statements? I'd >> be happy to write up a patch for the latter. > I'd rather not relax the rules but find a solution so that the rules work. > I happen to like the single line braces rule. That is, I don't like how the code looks (I dislike punctuation generally), but I like the consistency and I like how patches that add or remove a line are easy to read. My preference would be: new code has to adhere to the new style. Perhaps we can have a bot subscribed to the list issue auto-reviews if things are incorrect. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.