From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34608 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnH2K-0004aF-1R
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:21:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OnH2I-0000J7-Oz
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:20:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29659)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OnH2I-0000Iv-HY
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:20:58 -0400
Message-ID: <4C7186A6.7030107@redhat.com>
Date: Sun, 22 Aug 2010 22:20:54 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
References: <AANLkTikc=-mLwgK4WkhMEuhxbzVuiMn354=agB11H4W1@mail.gmail.com>	<alpine.LNX.2.00.1008122251300.1975@linmac>	<AANLkTin34MbLNV7N+cQVtft2q6BkgAD2nA6oBASk9oah@mail.gmail.com>	<AANLkTimM5aaYyfTkOpN-EpTqKM6uKLMv7E9ioGxdYudS@mail.gmail.com>	<4C6A4291.1020105@redhat.com>
	<4C6A8CD8.2080701@codemonkey.ws>	<4C6A94D0.2090201@redhat.com>	<AANLkTineoPuui02ONpk7ZNDKyVAfBJmrtmgVCxWTCz_3@mail.gmail.com>	<4C6D3260.8010103@redhat.com>
	<AANLkTi=sMV1NL=gHNx60FKQTAeKfh9G2FT2CCz_PjfSb@mail.gmail.com>
	<4C71856B.2050109@redhat.com>
In-Reply-To: <4C71856B.2050109@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Miguel Di Ciurcio Filho <miguel.filho@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

On 08/22/10 22:15, Avi Kivity wrote:
>  On 08/19/2010 09:29 PM, Blue Swirl wrote:
>>
>>> Just to be sure I follow, are you suggesting we relax all of the bracing
>>> rule, or just the part about braces around single line statements? I'd
>>> be happy to write up a patch for the latter.
>> I'd rather not relax the rules but find a solution so that the rules
>> work.
> 
> I happen to like the single line braces rule.  That is, I don't like how
> the code looks (I dislike punctuation generally), but I like the
> consistency and I like how patches that add or remove a line are easy to
> read.
> 
> My preference would be: new code has to adhere to the new style.

Agreed, once we pick something, make the new stuff stick to that. The
main issue is when you make mods to a file that is using a different
style. It's not ideal that you add one line of the new style and the
rest is the old way.

> Perhaps we can have a bot subscribed to the list issue auto-reviews if
> things are incorrect.

That might work.

Cheers,
Jes