From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] SATA / AHCI: Do not play with the link PM during suspend to RAM Date: Tue, 24 Aug 2010 09:37:34 +0200 Message-ID: <4C7376BE.5040006@gmail.com> References: <201007091750.05020.stephan.diestelhorst@amd.com> <201008191823.57915.stephan.diestelhorst@amd.com> <4C72639C.6090108@gmail.com> <201008232058.33542.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:45685 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128Ab0HXHmh (ORCPT ); Tue, 24 Aug 2010 03:42:37 -0400 In-Reply-To: <201008232058.33542.rjw@sisk.pl> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: "Rafael J. Wysocki" Cc: Stephan Diestelhorst , "linux-kernel@vger.kernel.org" , "linux-ide@vger.kernel.org" , "linux-pm@lists.osdl.org" , Stephan Diestelhorst On 08/23/2010 08:58 PM, Rafael J. Wysocki wrote: > On Monday, August 23, 2010, Tejun Heo wrote: >> Hello, sorry about the delay. >> >> On 08/19/2010 06:23 PM, Stephan Diestelhorst wrote: >>> It says "max_performance", I have not touched anyhting. So it has been >>> like that all the time. Would this explain why your patch did not show >>> the debug printout? >> >> Hmm... okay. Yeah, if you haven't been using IPM at all, there won't >> be any debug messages but at the same time the posted patch should >> have had the same effect as Rafael's patch as IPM path isn't traveled >> at all. Can you please check the followings? >> >> * You're actually running the correct patched kernel and modules. It >> probably is a good idea to add a printk message. ie. Apply the >> patch and add a printk() in ata_host_request_pm() in libata-core.c >> and make sure the debug messages appears. >> >> * Rafael's patch actually fixes the problem. If you haven't been >> using IPM at all, Rafael's patch and mine should behave exactly the >> same (ie. no IPM operation at all during suspend/resume). It could >> be that you're seeing a different issue. >> >> Rafael, can you please test my patch and see how your case behaves? > > This one: http://lkml.org/lkml/2010/8/5/328 ? Yeap, that one. I can prep a test git branch if necessary. Thanks. -- tejun