From: Stephen Marron <debian@solo.boxfusion.net>
To: linux-ppp@vger.kernel.org
Subject: multilink with nodetach [PATCH]
Date: Tue, 24 Aug 2010 09:07:24 +0000 [thread overview]
Message-ID: <4C7388FC.8010802@solo.boxfusion.net> (raw)
Hi
This bug has been Reported in the Debian BTS as bug 538107
http://bugs.debian.org/578070
If pppd is used with l2tpd (nodetach) in a multilink situation then this
feature of pppd causes problems
MULTILINK
If the first link terminates (for example, because of a
hangup or a received LCP terminate-request) the bundle is
not destroyed unless there are no other links remaining in the
bundle. Rather than exiting, the first pppd keeps running
after its link terminates, until all the links in the bundle
have terminated.
pppd remains connected to l2tpd even though it is just acting as a
multilink master, causing l2tpd to believe that pppd is connected... i
have resolved the issue in my own system by instructing pppd to detach
from the terminal after it changes to PHASE_MASTER i have been using
this patch since 2009-02-19 in our production systems and havent had any
problems
The "if (!detached)" call is redundant since the detach function already
checks if the process is detached so can be optionally excluded
I have noticed other people complaining of similar issues when using
multilink/nodetach in other setups (eg pppoe) I believe that this patch
may also solve the problem for them, but i have not tested that setup
-----
diff --git a/pppd/auth.c b/pppd/auth.c
index fb71944..62648b8 100644
--- a/pppd/auth.c
+++ b/pppd/auth.c
@@ -669,8 +669,11 @@ link_terminated(unit)
(*the_channel->cleanup)();
if (doing_multilink && multilink_master) {
- if (!bundle_terminating)
+ if (!bundle_terminating) {
new_phase(PHASE_MASTER);
+ if (!detached)
+ detach();
+ }
else
mp_bundle_terminated();
} else
-----
feedback is appreciated :)
Regards
Stephen
next reply other threads:[~2010-08-24 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 9:07 Stephen Marron [this message]
2010-10-20 5:35 multilink with nodetach [PATCH] Stephen Marron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7388FC.8010802@solo.boxfusion.net \
--to=debian@solo.boxfusion.net \
--cc=linux-ppp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.