All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2/dlm: dynamically allocate lvb for dlm_lock_resource
Date: Wed, 25 Aug 2010 05:43:18 -0700	[thread overview]
Message-ID: <4C750FE6.2070207@oracle.com> (raw)
In-Reply-To: <20100825123126.GA3134@laptop.jp.oracle.com>

  On 8/25/2010 5:31 AM, Wengang Wang wrote:
> It looks we can't move it to the very top.
> The caller doesn't make sure we need to update lvb. In other words, it
> treat the lockres' that need lvb and those don't the same. We have to
> distinguish them in dlm_update_lvb() its self. And I think checking
> DLM_LKSB_GET_LVB flag is the right place to place the assertion.
>
> Or do you meant we should treat different type (lvb needed or no) of
> lockress differently in the callers?(though I don't think you meant this)

ok.

>
> Actually I alreay have another similar patch which dynamically allocates
> lvb for dlm_lock. dlm_alloc_lvb() is used in that patch. So allocating
> lvb is in a separated function.
> Since the patch for dlm_lock is much more complex than this one, I
> didn't post it out together before this one gets approved.
>
> Anyway if you persist, I can make it as you wanted.

Then post both the patches.

      reply	other threads:[~2010-08-25 12:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-21 23:13 [Ocfs2-devel] [PATCH] ocfs2/dlm: dynamically allocate lvb for dlm_lock_resource Wengang Wang
2010-08-24 18:09 ` Sunil Mushran
2010-08-25 12:31   ` Wengang Wang
2010-08-25 12:43     ` Sunil Mushran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C750FE6.2070207@oracle.com \
    --to=sunil.mushran@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.