From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Fri, 27 Aug 2010 07:37:05 +0200 Subject: [U-Boot] [PATCH] Orion5x: bugfix: window size (mis)calculation In-Reply-To: <4C774652.6090200@free.fr> References: <1282656460-10999-1-git-send-email-albert.aribaud@free.fr> <4C774652.6090200@free.fr> Message-ID: <4C774F01.3020703@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 27/08/2010 07:00, Chris Moore a ?crit : > Hi list, Hi Chris! > [...] > For range 0x00000000 to 0x00000000 Chris Moore's fast > orion5x_winctrl_calcsize returns 0xffff > [...] > For range 0x80000001 to 0xffffffff Chris Moore's fast > orion5x_winctrl_calcsize returns 0xffff > > AIUI (apart from the question of how best to handle a size of 0) this is > the required result. I think your proposal to handle size 0 as meaning '4 MB' is fine, since there is no way to express 4MB and a zero size is meaningless as such. > If I have misunderstood, please tell me and I'll rewrite. That's fine. Do you want me to resubmit a V2 patch with your change, or will you subit it yourself? > HTH. It does, as does every fix that brings orion/kirkwood U-boot nearer to industry strength. :) > Cheers, > Chris Amicalement, -- Albert.