From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753636Ab0H0NtM (ORCPT ); Fri, 27 Aug 2010 09:49:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10118 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753533Ab0H0NtK (ORCPT ); Fri, 27 Aug 2010 09:49:10 -0400 Message-ID: <4C77C20F.1050405@redhat.com> Date: Fri, 27 Aug 2010 09:47:59 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.1 MIME-Version: 1.0 To: Wu Fengguang CC: Andrew Morton , KOSAKI Motohiro , Neil Brown , Con Kolivas , Jan Kara , Peter Zijlstra , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "david@fromorbit.com" , "hch@lst.de" , "axboe@kernel.dk" Subject: Re: [PATCH] writeback: remove the internal 5% low bound on dirty_ratio References: <20100827103603.GB6237@localhost> In-Reply-To: <20100827103603.GB6237@localhost> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/27/2010 06:36 AM, Wu Fengguang wrote: > The dirty_ratio was siliently limited in global_dirty_limits() to>= 5%. > This is not a user expected behavior. And it's inconsistent with > calc_period_shift(), which uses the plain vm_dirty_ratio value. > > Let's rip the internal bound. > > At the same time, fix balance_dirty_pages() to work with the > dirty_thresh=0 case. This allows applications to proceed when > dirty+writeback pages are all cleaned. > > And ">" fits with the name "exceeded" better than">=" does. Neil > think it is an aesthetic improvement as well as a functional one :) > > CC: Jan Kara > CC: Rik van Riel > CC: Peter Zijlstra > Proposed-by: Con Kolivas > Reviewed-by: Neil Brown > Reviewed-by: KOSAKI Motohiro > Signed-off-by: Wu Fengguang Reviewed-by: Rik van Riel -- All rights reversed From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rik van Riel Subject: Re: [PATCH] writeback: remove the internal 5% low bound on dirty_ratio Date: Fri, 27 Aug 2010 09:47:59 -0400 Message-ID: <4C77C20F.1050405@redhat.com> References: <20100827103603.GB6237@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Andrew Morton , KOSAKI Motohiro , Neil Brown , Con Kolivas , Jan Kara , Peter Zijlstra , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "david@fromorbit.com" , "hch@lst.de" , "axboe@kernel.dk" To: Wu Fengguang Return-path: In-Reply-To: <20100827103603.GB6237@localhost> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On 08/27/2010 06:36 AM, Wu Fengguang wrote: > The dirty_ratio was siliently limited in global_dirty_limits() to>= 5%. > This is not a user expected behavior. And it's inconsistent with > calc_period_shift(), which uses the plain vm_dirty_ratio value. > > Let's rip the internal bound. > > At the same time, fix balance_dirty_pages() to work with the > dirty_thresh=0 case. This allows applications to proceed when > dirty+writeback pages are all cleaned. > > And ">" fits with the name "exceeded" better than">=" does. Neil > think it is an aesthetic improvement as well as a functional one :) > > CC: Jan Kara > CC: Rik van Riel > CC: Peter Zijlstra > Proposed-by: Con Kolivas > Reviewed-by: Neil Brown > Reviewed-by: KOSAKI Motohiro > Signed-off-by: Wu Fengguang Reviewed-by: Rik van Riel -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org