Re: [PATCH] ibnetdiscover: add '-f' flag to show full information (ports' speed and width).

From: "Eli Dorfman (Voltaire)" <dorfman.eli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Cc: Hal Rosenstock
	<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Doron Shoham <dorons-smomgflXvOZWk0Htik3J/w@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ibnetdiscover: add '-f' flag to show full information (ports' speed and width).
Date: Tue, 31 Aug 2010 17:18:46 +0300	[thread overview]
Message-ID: <4C7D0F46.1030305@gmail.com> (raw)
In-Reply-To: <20100825170656.GM5837@me>

Sasha Khapyorsky wrote:
> On 09:45 Tue 24 Aug     , Hal Rosenstock wrote:
>>> What about the flag? do we still need it if we pass the output after the comment?
>> I wouldn't think so. I also think we've made commentary changes to the
>> ibnetdiscover output format like this before. If we wanted to be
>> absolutely sure it wouldn't break anything, we'd keep the flag though.
>> It's up to Sasha.
> 
> The '-f' flag could make sense since those information actually
> duplicates previous 4xDDR, etc. and used by ibsim's parser only.
> 
> Also it would be nice to make ibsim's parser to understand both
> possibilities: s=2 and speed=2 (Or even to parse "*x*DR" strings :))

Is it valid to assume that "*x*DR" string is always the last token?
If so, the patch should be changed

Eli
> 
> Sasha
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html