All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trilok Soni <tsoni@codeaurora.org>
To: Neil Leeder <nleeder@codeaurora.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, Hsin.Wu@quantatw.com,
	Horace Fu <horace.fu@quantatw.com>
Subject: Re: [PATCH 1/1] input: keyboard: add qci keyboard driver
Date: Thu, 02 Sep 2010 14:21:14 +0530	[thread overview]
Message-ID: <4C7F6582.6060108@codeaurora.org> (raw)
In-Reply-To: <1282947517-32118-1-git-send-email-nleeder@codeaurora.org>

Hi Neil,

On 8/28/2010 3:48 AM, Neil Leeder wrote:
> +	__set_bit(EV_KEY, context->qcikbd_dev->evbit);
> +	__set_bit(EV_REP, context->qcikbd_dev->evbit);

If you are going to roll out new version of this patch to address the last
comment from Dmitry, then I have couple of suggestions. If possible
then please incorporate.

Make EV_REP optional, not all the systems needs it by default. Better to introduce
pdata->rep.

Some of the systems would need each key press to wake up the system, so
disable_irq in suspend would not be what they want. How about introducing
pdata->wakeup flag and then using device_init_wakeup, device_may_wakeup,
enable/disable_irq_wake friends in probe and .suspend/.resume functions.

---Trilok Soni

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2010-09-02  8:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-27 22:14 [PATCH 0/1] input: keyboard: add qci keyboard driver Neil Leeder
2010-08-27 22:18 ` [PATCH 1/1] " Neil Leeder
2010-09-02  8:51   ` Trilok Soni [this message]
2010-08-27 22:33 ` [PATCH 0/1] " Dmitry Torokhov
2010-08-30 18:22   ` Neil Leeder
2010-08-30 21:55     ` Dmitry Torokhov
2010-08-31 20:54       ` Neil Leeder
2010-09-01  6:34         ` Dmitry Torokhov
2010-09-03 19:13           ` Neil Leeder
2010-09-03 20:37             ` Dmitry Torokhov
2010-09-07 21:57               ` Neil Leeder
2010-09-07 22:14                 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C7F6582.6060108@codeaurora.org \
    --to=tsoni@codeaurora.org \
    --cc=Hsin.Wu@quantatw.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=horace.fu@quantatw.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nleeder@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.