All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux-fsdevel@vger.kernel.org
Cc: bugzilla-daemon@bugzilla.kernel.org,
	linux-kernel@vger.kernel.org, Dave Chinner <david@fromorbit.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [Bug 17752] 2.6.36-rc3: inconsistent lock state (iprune_sem, shrink_icache_memory)
Date: Fri, 03 Sep 2010 23:34:56 +0200	[thread overview]
Message-ID: <4C816A00.9030507@s5r6.in-berlin.de> (raw)
In-Reply-To: <201009031907.o83J7tdw011454@demeter1.kernel.org>

bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=17752
> 
> 
> Maciej Rutecki <maciej.rutecki@gmail.com> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Blocks|                            |16444

This is probably not a regression.  See this earlier discussion:
http://lkml.org/lkml/2010/1/15/76

And another report, coincidentally at the same time:
http://lkml.org/lkml/2010/1/18/108

As I understand Christoph's post on January 19, several code paths are
independently affected:
http://lkml.org/lkml/2010/1/19/267
(Maybe some of those have been fixed in the meantime.)

I don't see in my trace from September 1 which filesystem caused the
particular lockdep report.  I may have unmounted ext4, vfat, or fuse prior to
that.

Dave wrote on September 2:
>> Any memory allocation that enters reclaim in the unmount path will
>> generate this warning. The problem is that the normal memory reclaim
>> path is:
>> 
>> 	alloc -> reclaim -> shrink_slab -> shrink_icache_memory -> iprune_sem -> s_umount
>> 
>> while unmmount does:
>> 
>> 	unmount -> s_umount -> alloc -> lockdep goes boom!
>> or
>> 	unmount -> iprune_sem -> alloc -> lockdep goes boom!
>> 
>> I never got a straight answer on this, but it the warnings are
>> indicating that you must use GFP_NOFS allocations for every
>> allocation in the unmount path, which is kind of hard to know
>> about given the code is not unomunt path specific....

Is it feasible to add a gfp_flag argument to all call chains that could lead
to allocations in unmount?
-- 
Stefan Richter
-=====-==-=- =--= ---==
http://arcgraph.de/sr/

       reply	other threads:[~2010-09-03 21:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-17752-4803@https.bugzilla.kernel.org/>
     [not found] ` <201009031907.o83J7tdw011454@demeter1.kernel.org>
2010-09-03 21:34   ` Stefan Richter [this message]
2010-09-12 18:11 2.6.36-rc3-git5: Reported regressions from 2.6.35 Rafael J. Wysocki
2010-09-12 18:14 ` [Bug #17752] 2.6.36-rc3: inconsistent lock state (iprune_sem, shrink_icache_memory) Rafael J. Wysocki
2010-09-12 18:14   ` Rafael J. Wysocki
2010-09-20 18:47 2.6.36-rc4-git5: Reported regressions from 2.6.35 Rafael J. Wysocki
2010-09-20 19:08 ` [Bug #17752] 2.6.36-rc3: inconsistent lock state (iprune_sem, shrink_icache_memory) Rafael J. Wysocki
2010-09-20 19:08   ` Rafael J. Wysocki
2010-09-20 20:45   ` Stefan Richter
2010-09-20 20:45     ` Stefan Richter
2010-09-20 21:03     ` Rafael J. Wysocki
2010-09-20 21:03       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C816A00.9030507@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=bugzilla-daemon@bugzilla.kernel.org \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.