From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752839Ab0IJOmJ (ORCPT ); Fri, 10 Sep 2010 10:42:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53242 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808Ab0IJOmI (ORCPT ); Fri, 10 Sep 2010 10:42:08 -0400 Message-ID: <4C8A43A9.2030907@redhat.com> Date: Fri, 10 Sep 2010 10:41:45 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100806 Fedora/3.1.2-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.2 MIME-Version: 1.0 To: Naoya Horiguchi CC: LKML , Andrea Arcangeli , Hugh Dickins , Christoph Lameter , Linus Torvalds , Andrew Morton , Peter Zijlstra , Andi Kleen , linux-mm Subject: Re: [PATCH 3/4] hugetlb, rmap: fix confusing page locking in hugetlb_cow() References: <1284092586-1179-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1284092586-1179-4-git-send-email-n-horiguchi@ah.jp.nec.com> In-Reply-To: <1284092586-1179-4-git-send-email-n-horiguchi@ah.jp.nec.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/2010 12:23 AM, Naoya Horiguchi wrote: > if(!trylock_page) block in avoidcopy path of hugetlb_cow() looks confusing > and is buggy. Originally this trylock_page() is intended to make sure > that old_page is locked even when old_page != pagecache_page, because then > only pagecache_page is locked. > This patch fixes it by moving page locking into hugetlb_fault(). > > Signed-off-by: Naoya Horiguchi Acked-by: Rik van Riel -- All rights reversed From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 26F726B00AE for ; Fri, 10 Sep 2010 10:42:06 -0400 (EDT) Message-ID: <4C8A43A9.2030907@redhat.com> Date: Fri, 10 Sep 2010 10:41:45 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 3/4] hugetlb, rmap: fix confusing page locking in hugetlb_cow() References: <1284092586-1179-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1284092586-1179-4-git-send-email-n-horiguchi@ah.jp.nec.com> In-Reply-To: <1284092586-1179-4-git-send-email-n-horiguchi@ah.jp.nec.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Naoya Horiguchi Cc: LKML , Andrea Arcangeli , Hugh Dickins , Christoph Lameter , Linus Torvalds , Andrew Morton , Peter Zijlstra , Andi Kleen , linux-mm List-ID: On 09/10/2010 12:23 AM, Naoya Horiguchi wrote: > if(!trylock_page) block in avoidcopy path of hugetlb_cow() looks confusing > and is buggy. Originally this trylock_page() is intended to make sure > that old_page is locked even when old_page != pagecache_page, because then > only pagecache_page is locked. > This patch fixes it by moving page locking into hugetlb_fault(). > > Signed-off-by: Naoya Horiguchi Acked-by: Rik van Riel -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org