From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 18/24] Exiting from L2 to L1 Date: Mon, 13 Sep 2010 10:48:38 +0200 Message-ID: <4C8DE566.3000301@redhat.com> References: <1276431753-nyh@il.ibm.com> <201006131231.o5DCVlKB013102@rice.haifa.ibm.com> <4C161AB8.4060905@redhat.com> <20100912140530.GA26346@fermat.math.technion.ac.il> <4C8CE3E2.7060708@redhat.com> <20100912170503.GA7828@fermat.math.technion.ac.il> <4C8D0C19.4050003@redhat.com> <20100912195117.GA11002@fermat.math.technion.ac.il> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Sheng Yang To: "Nadav Har'El" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:5444 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754380Ab0IMIst (ORCPT ); Mon, 13 Sep 2010 04:48:49 -0400 In-Reply-To: <20100912195117.GA11002@fermat.math.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: On 09/12/2010 09:51 PM, Nadav Har'El wrote: > >> There are two cases where VM_ENTRY_INTR_INFO_FIELD can potentially not >> be cleared by hardware: >> ... >> If neither of these are valid, the code can be removed. If only the >> second, we might make it conditional. > Again, unless I'm misunderstanding what you mean, the hardware only > modified vmcs02 (the hardware vmcs), not vmcs12. We need to modify vmcs12 > as well, to remove the "valid" bit. If we don't, when L1 enters into the same > L2 again, the same old value will be copied again from vmcs12 to vmcs02, > and cause an injection of the same interrupt again. Yes, vmcs12 still needs to be updated. So the code cannot be removed, just the vm -- error compiling committee.c: too many arguments to function