Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35

[Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

On 09/13/2010 02:07 PM, Masayuki Ohtake wrote:
>> - Try to send patches directly with git send-email
> In our network environment, we can't use send-email.

that's bad...talk to your IT department :)

>> - don't use global variables
> I have modified so that our patch doesn't use global variable except module parameter.
>
>> - don't use that "int handle", e.g.:
> I have deleted.
>
>
>> - get rid of the intermediate struct pch_can_msg:
>>    Your data path is:
>>    struct can_frame ->  struct pch_can_msg ->  registers
>>    write from struct can_frame into registers directly
> Since Topcliff CAN HW register assign is different from struct can_frame,
> I think intermediate structure is necessary.

I don't see any reason for this. No other driver has an intermediate 
struct. Look at the other drivers.

>> - what's the purpose of "p_can_os->can_callback", call the function
>>    directly from the interrupt handler
> I have deleted
>
>> - implement NAPI
> Since Topcliff CAN HW register has only single rx buffer,
> I think NAPI is unnecessary.

Doesn't matter. Please try to implement it.

>> - get rid of "1<<  BIT_SHIFT_SIX" and friend,
>>    use "1<<  6" or "BIT(6)" if you like defines
> I have modified.
>
>> - use defines to set bits in struct can_frame can_id
> I have modified.
>
> I will resubmit modified our CAN patch soon.
>
> Thanks, Ohtake(OKISemi)

cheers, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |