All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Bian Naimeng <biannm@cn.fujitsu.com>
Cc: linux-nfs@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH] rpc.idmapd: Type of idmap client should be defined by ic_id not ic_clid.
Date: Thu, 16 Sep 2010 07:15:00 -0400	[thread overview]
Message-ID: <4C91FC34.8040401@RedHat.com> (raw)
In-Reply-To: <4C8EE506.1020509@cn.fujitsu.com>



On 09/13/2010 10:59 PM, Bian Naimeng wrote:
> The type of idmap_client is defined by idmap_client.ic_id for nfs,
> so nfsd should have the same style.
> 
> Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
Committed...

steved.

> 
> ---
>  utils/idmapd/idmapd.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/utils/idmapd/idmapd.c b/utils/idmapd/idmapd.c
> index 9ecab66..b76607a 100644
> --- a/utils/idmapd/idmapd.c
> +++ b/utils/idmapd/idmapd.c
> @@ -119,8 +119,8 @@ struct idmap_client {
>  static struct idmap_client nfsd_ic[2] = {
>  {
>  	.ic_which = IC_IDNAME, 
> -	.ic_clid = "Server", 
> -	.ic_id = "", 
> +	.ic_clid = "", 
> +	.ic_id = "Server", 
>  	.ic_path = IC_IDNAME_CHAN, 
>  	.ic_fd = -1, 
>  	.ic_dirfd = -1, 
> @@ -128,8 +128,8 @@ static struct idmap_client nfsd_ic[2] = {
>  },
>  {
>  	.ic_which = IC_NAMEID, 
> -	.ic_clid = "Server", 
> -	.ic_id = "", 
> +	.ic_clid = "", 
> +	.ic_id = "Server", 
>  	.ic_path = IC_NAMEID_CHAN, 
>  	.ic_fd = -1, 
>  	.ic_dirfd = -1, 
> -- 1.6.5.2
> -- Regards Bian Naimeng

      reply	other threads:[~2010-09-16 11:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-14  2:59 [PATCH] rpc.idmapd: Type of idmap client should be defined by ic_id not ic_clid Bian Naimeng
2010-09-16 11:15 ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C91FC34.8040401@RedHat.com \
    --to=steved@redhat.com \
    --cc=biannm@cn.fujitsu.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.