From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] p1022ds: use weak CFI flash accessors when DIU is enabled
Date: Thu, 16 Sep 2010 16:18:16 -0500 [thread overview]
Message-ID: <4C928998.4040805@freescale.com> (raw)
In-Reply-To: <20100916211338.39FF015242D@gemini.denx.de>
Wolfgang Denk wrote:
> I think the description is wrong - don't you switch from DIU to LBC
> for flash access?
Ugh, yes. I was getting bug-eyed working on this code.
>> +/* Variables used by the DIU/LBC switching code. It's safe to makes these
>> + * global, because the DIU requires DDR, so we'll only run this code after
>> + * relocation.
>> + */
>
> Incorrect multiline comment format.
>
>> +/**
>> + * set_mux_to_lbc - disable the DIU so that we can read/write to elbc
>
> Incorrect multiline comment format. Please check and fix globally.
Can you be more specific? Is it the "**"?
>> +#define CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS
>> +/*
>> + * With CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS, flash I/O is really slow, so
>> + * disable empty flash sector detection, which is I/O-intensive.
>> + */
>> +#undef CONFIG_SYS_FLASH_EMPTY_INFO
>
> "#ifdef CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS" / "#endif" arount the
> #undef ?
Why? CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS is only defined if CONFIG_VIDEO is
defined. It's just one block of macros.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2010-09-16 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 20:08 [U-Boot] [PATCH] p1022ds: use weak CFI flash accessors when DIU is enabled Timur Tabi
2010-09-16 21:13 ` Wolfgang Denk
2010-09-16 21:18 ` Timur Tabi [this message]
2010-09-16 21:29 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C928998.4040805@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.