From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
yuanding02@gmail.com
Subject: Re: [PATCH #upstream 1/3] libata: add @ap to ata_wait_register() and introduce ata_msleep()
Date: Fri, 17 Sep 2010 02:11:08 -0400 [thread overview]
Message-ID: <4C93067C.5010405@garzik.org> (raw)
In-Reply-To: <4C850F2D.4030601@kernel.org>
On 09/06/2010 11:56 AM, Tejun Heo wrote:
> Add optional @ap argument to ata_wait_register() and replace msleep()
> calls with ata_msleep() which take optional @ap in addition to the
> duration. These will be used to implement EH exclusion.
>
> This patch doesn't cause any behavior difference.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> ---
> These three patches fix the long-standing EH exclusion bug which was
> reported more than three years ago and recently caused obscure
> problems during parallel probing for ata_piix w/ SIDPR.
>
> It basically implements EH big lock which guarantees that only single
> EH of a host is running. This achieves proper EH exclusion without
> pervasive changes to each driver which would be fragile while not
> harming parallel probing/EH too much.
>
> Thanks.
>
> drivers/ata/libahci.c | 18 +++++++++---------
> drivers/ata/libata-core.c | 21 ++++++++++++++-------
> drivers/ata/libata-eh.c | 2 +-
> drivers/ata/libata-sff.c | 12 ++++++------
> drivers/ata/pata_bf54x.c | 4 ++--
> drivers/ata/pata_samsung_cf.c | 2 +-
> drivers/ata/pata_scc.c | 4 ++--
> drivers/ata/sata_fsl.c | 19 ++++++++++---------
> drivers/ata/sata_inic162x.c | 2 +-
> drivers/ata/sata_sil24.c | 14 +++++++-------
> drivers/ata/sata_via.c | 2 +-
> include/linux/libata.h | 5 +++--
> 12 files changed, 57 insertions(+), 48 deletions(-)
applied
prev parent reply other threads:[~2010-09-17 6:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 15:56 [PATCH #upstream 1/3] libata: add @ap to ata_wait_register() and introduce ata_msleep() Tejun Heo
2010-09-06 15:57 ` [PATCH #upstream 2/3] libata: implement cross-port EH exclusion Tejun Heo
2010-09-06 15:57 ` [PATCH #upstream 3/3] ata_piix: remove SIDPR locking Tejun Heo
2010-09-17 6:11 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C93067C.5010405@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yuanding02@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.