From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] kvm: enable irq injection from interrupt context
Date: Sun, 19 Sep 2010 13:05:09 +0200 [thread overview]
Message-ID: <4C95EE65.3090209@redhat.com> (raw)
In-Reply-To: <20100919105512.GB7350@redhat.com>
On 09/19/2010 12:55 PM, Michael S. Tsirkin wrote:
> On Sun, Sep 19, 2010 at 12:56:12PM +0200, Avi Kivity wrote:
> > On 09/19/2010 12:45 PM, Michael S. Tsirkin wrote:
> > >On Fri, Sep 17, 2010 at 09:59:29AM +0200, Gleb Natapov wrote:
> > >> > writing 0 to eventfd does nothing. The way to deassert irq
> > >> That is implementation detail of current irqfd. It was designed for MSI
> > >> not level triggered interrupts.
> > >
> > >Maybe we should add a check that gsi is mapped to MSI (or unmapped) then?
> > >Level which switches to 1 and back to 0 immediately will be racy anyway
> > >...
> > >
> >
> > Add a check where?
>
> I would make sure that if you bind irqfd to a non-MSI GSI,
> signalling it has no effect.
>
Certainly. We should also update the documentation, when we have irqfd
documentation.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-09-19 11:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 18:54 [PATCH RFC] kvm: enable irq injection from interrupt context Michael S. Tsirkin
2010-09-16 9:02 ` Gleb Natapov
2010-09-16 9:10 ` Michael S. Tsirkin
2010-09-16 9:25 ` Gleb Natapov
2010-09-16 9:43 ` Michael S. Tsirkin
2010-09-16 9:46 ` Avi Kivity
2010-09-16 9:53 ` Michael S. Tsirkin
2010-09-16 10:13 ` Gleb Natapov
2010-09-16 10:13 ` Michael S. Tsirkin
2010-09-16 10:20 ` Gleb Natapov
2010-09-16 10:44 ` Michael S. Tsirkin
2010-09-16 10:54 ` Gleb Natapov
2010-09-16 10:53 ` Michael S. Tsirkin
2010-09-16 11:17 ` Gleb Natapov
2010-09-16 12:13 ` Michael S. Tsirkin
2010-09-16 12:33 ` Gleb Natapov
2010-09-16 12:57 ` Michael S. Tsirkin
2010-09-16 13:14 ` Avi Kivity
2010-09-16 13:38 ` Michael S. Tsirkin
2010-09-16 13:50 ` Avi Kivity
2010-09-16 13:55 ` Gleb Natapov
2010-09-16 13:18 ` Gleb Natapov
2010-09-16 13:51 ` Michael S. Tsirkin
2010-09-16 14:06 ` Gleb Natapov
2010-09-16 14:23 ` Michael S. Tsirkin
2010-09-16 14:51 ` Gleb Natapov
2010-09-16 15:24 ` Michael S. Tsirkin
2010-09-16 15:43 ` Gleb Natapov
2010-09-16 22:07 ` Michael S. Tsirkin
2010-09-17 7:59 ` Gleb Natapov
2010-09-19 10:45 ` Michael S. Tsirkin
2010-09-19 10:56 ` Avi Kivity
2010-09-19 10:55 ` Michael S. Tsirkin
2010-09-19 11:05 ` Avi Kivity [this message]
2010-09-19 11:23 ` Michael S. Tsirkin
2010-09-19 11:18 ` Gleb Natapov
2010-09-19 11:21 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C95EE65.3090209@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.