From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Joey Lee" Subject: Re: [PATCH] Add Intel Poulsbo Stub Driver Date: Sun, 19 Sep 2010 10:35:26 -0600 Message-ID: <4C96C86E020000230002090E@novprvlin0050.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: mjg59@srcf.ucam.org Cc: randy.dunlap@oracle.com, mjg@redhat.com, gregkh@suse.de, trenn@suse.de, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Valdis.Kletnieks@vt.edu, Dennis.Jansen@web.de Hi Matthew,=20 I modified the help description to add GMA500. Could you please give my any suggestion for this stub driver? Does it good enough to put into kernel ? Thank's a lot! Joey Lee =E6=96=BC =E4=B8=89=EF=BC=8C2010-09-15 =E6=96=BC 22:24 +0800=EF=BC=8CLe= e, Chun-Yi =E6=8F=90=E5=88=B0=EF=BC=9A > Currently, there have no GMA500(Poulsbo) native video driver to suppo= rt > intel opregion. So, use this stub driver to enable the acpi backlight > control sysfs entry files by requrest acpi_video_register. >=20 > Signed-off-by: Lee, Chun-Yi > --- > drivers/gpu/Makefile | 2 +- > drivers/gpu/stub/Kconfig | 13 +++++++++ > drivers/gpu/stub/Makefile | 1 + > drivers/gpu/stub/poulsbo.c | 63 ++++++++++++++++++++++++++++++++++= ++++++++++ > drivers/video/Kconfig | 2 + > 5 files changed, 80 insertions(+), 1 deletions(-) > create mode 100644 drivers/gpu/stub/Kconfig > create mode 100644 drivers/gpu/stub/Makefile > create mode 100644 drivers/gpu/stub/poulsbo.c >=20 > diff --git a/drivers/gpu/Makefile b/drivers/gpu/Makefile > index 30879df..cc92778 100644 > --- a/drivers/gpu/Makefile > +++ b/drivers/gpu/Makefile > @@ -1 +1 @@ > -obj-y +=3D drm/ vga/ > +obj-y +=3D drm/ vga/ stub/ > diff --git a/drivers/gpu/stub/Kconfig b/drivers/gpu/stub/Kconfig > new file mode 100644 > index 0000000..8f5a540 > --- /dev/null > +++ b/drivers/gpu/stub/Kconfig > @@ -0,0 +1,13 @@ > +config STUB_POULSBO > + tristate "Intel GMA500 Stub Driver" > + depends on PCI > + # Poulsbo stub depends on ACPI_VIDEO when ACPI is enabled > + # but for select to work, need to select ACPI_VIDEO's depend= encies, ick > + select ACPI_VIDEO if ACPI > + help > + Choose this option if you have a system that has Intel GMA500 > + (Poulsbo) integrated graphics. If M is selected, the module will > + be called Poulsbo. This driver is a stub driver for Poulsbo that > + will call poulsbo.ko to enable the acpi backlight control sysfs > + entry file because there have no poulsbo native driver can suppor= t > + intel opregion. > diff --git a/drivers/gpu/stub/Makefile b/drivers/gpu/stub/Makefile > new file mode 100644 > index 0000000..cd940cc > --- /dev/null > +++ b/drivers/gpu/stub/Makefile > @@ -0,0 +1 @@ > +obj-$(CONFIG_STUB_POULSBO) +=3D poulsbo.o > diff --git a/drivers/gpu/stub/poulsbo.c b/drivers/gpu/stub/poulsbo.c > new file mode 100644 > index 0000000..d8aa636 > --- /dev/null > +++ b/drivers/gpu/stub/poulsbo.c > @@ -0,0 +1,63 @@ > +/* > + * Intel Poulsbo Stub driver > + * > + * Copyright (C) 2010 Novell > + * > + * This program is free software; you can redistribute it and/or mod= ify it > + * under the terms of the GNU General Public License version 2 as pu= blished by > + * the Free Software Foundation. > + * > + */ > + > +#include > +#include > +#include > + > +#define DRIVER_NAME "poulsbo" > + > +enum { > + CHIP_PSB_8108 =3D 0, > + CHIP_PSB_8109 =3D 1, > +}; > + > +static struct pci_device_id pciidlist[] =3D { > + {0x8086, 0x8108, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PSB_8108}, \ > + {0x8086, 0x8109, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PSB_8109}, \ > + {0, 0, 0} > +}; > + > +static int poulsbo_probe(struct pci_dev *pdev, const struct pci_devi= ce_id *id) > +{ > + return acpi_video_register(); > +} > + > +static void poulsbo_remove(struct pci_dev *pdev) > +{ > + acpi_video_unregister(); > +} > + > +static struct pci_driver poulsbo_driver =3D { > + .name =3D DRIVER_NAME, > + .id_table =3D pciidlist, > + .probe =3D poulsbo_probe, > + .remove =3D poulsbo_remove, > +}; > + > +static int __init poulsbo_init(void) > +{ > + return pci_register_driver(&poulsbo_driver); > +} > + > +static void __exit poulsbo_exit(void) > +{ > + pci_unregister_driver(&poulsbo_driver); > +} > + > +module_init(poulsbo_init); > +module_exit(poulsbo_exit); > + > +MODULE_AUTHOR("Lee, Chun-Yi "); > +MODULE_DESCRIPTION("Poulsbo Stub Driver"); > +MODULE_LICENSE("GPL"); > + > +MODULE_DEVICE_TABLE(pci, pciidlist); > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 8b31fdf..8807ae5 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -17,6 +17,8 @@ source "drivers/gpu/vga/Kconfig" > =20 > source "drivers/gpu/drm/Kconfig" > =20 > +source "drivers/gpu/stub/Kconfig" > + > config VGASTATE > tristate > default n -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754830Ab0ISQfg (ORCPT ); Sun, 19 Sep 2010 12:35:36 -0400 Received: from novprvlin0050.provo.novell.com ([137.65.248.33]:9379 "EHLO novprvlin0050.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934Ab0ISQfe (ORCPT ); Sun, 19 Sep 2010 12:35:34 -0400 Message-Id: <4C96C86E020000230002090E@novprvlin0050.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 8.0.2 Date: Sun, 19 Sep 2010 10:35:26 -0600 From: "Joey Lee" To: Cc: , , , , , , , Subject: Re: [PATCH] Add Intel Poulsbo Stub Driver Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthew, I modified the help description to add GMA500. Could you please give my any suggestion for this stub driver? Does it good enough to put into kernel ? Thank's a lot! Joey Lee 於 三，2010-09-15 於 22:24 +0800，Lee, Chun-Yi 提到： > Currently, there have no GMA500(Poulsbo) native video driver to support > intel opregion. So, use this stub driver to enable the acpi backlight > control sysfs entry files by requrest acpi_video_register. > > Signed-off-by: Lee, Chun-Yi > --- > drivers/gpu/Makefile | 2 +- > drivers/gpu/stub/Kconfig | 13 +++++++++ > drivers/gpu/stub/Makefile | 1 + > drivers/gpu/stub/poulsbo.c | 63 ++++++++++++++++++++++++++++++++++++++++++++ > drivers/video/Kconfig | 2 + > 5 files changed, 80 insertions(+), 1 deletions(-) > create mode 100644 drivers/gpu/stub/Kconfig > create mode 100644 drivers/gpu/stub/Makefile > create mode 100644 drivers/gpu/stub/poulsbo.c > > diff --git a/drivers/gpu/Makefile b/drivers/gpu/Makefile > index 30879df..cc92778 100644 > --- a/drivers/gpu/Makefile > +++ b/drivers/gpu/Makefile > @@ -1 +1 @@ > -obj-y += drm/ vga/ > +obj-y += drm/ vga/ stub/ > diff --git a/drivers/gpu/stub/Kconfig b/drivers/gpu/stub/Kconfig > new file mode 100644 > index 0000000..8f5a540 > --- /dev/null > +++ b/drivers/gpu/stub/Kconfig > @@ -0,0 +1,13 @@ > +config STUB_POULSBO > + tristate "Intel GMA500 Stub Driver" > + depends on PCI > + # Poulsbo stub depends on ACPI_VIDEO when ACPI is enabled > + # but for select to work, need to select ACPI_VIDEO's dependencies, ick > + select ACPI_VIDEO if ACPI > + help > + Choose this option if you have a system that has Intel GMA500 > + (Poulsbo) integrated graphics. If M is selected, the module will > + be called Poulsbo. This driver is a stub driver for Poulsbo that > + will call poulsbo.ko to enable the acpi backlight control sysfs > + entry file because there have no poulsbo native driver can support > + intel opregion. > diff --git a/drivers/gpu/stub/Makefile b/drivers/gpu/stub/Makefile > new file mode 100644 > index 0000000..cd940cc > --- /dev/null > +++ b/drivers/gpu/stub/Makefile > @@ -0,0 +1 @@ > +obj-$(CONFIG_STUB_POULSBO) += poulsbo.o > diff --git a/drivers/gpu/stub/poulsbo.c b/drivers/gpu/stub/poulsbo.c > new file mode 100644 > index 0000000..d8aa636 > --- /dev/null > +++ b/drivers/gpu/stub/poulsbo.c > @@ -0,0 +1,63 @@ > +/* > + * Intel Poulsbo Stub driver > + * > + * Copyright (C) 2010 Novell > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License version 2 as published by > + * the Free Software Foundation. > + * > + */ > + > +#include > +#include > +#include > + > +#define DRIVER_NAME "poulsbo" > + > +enum { > + CHIP_PSB_8108 = 0, > + CHIP_PSB_8109 = 1, > +}; > + > +static struct pci_device_id pciidlist[] = { > + {0x8086, 0x8108, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PSB_8108}, \ > + {0x8086, 0x8109, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PSB_8109}, \ > + {0, 0, 0} > +}; > + > +static int poulsbo_probe(struct pci_dev *pdev, const struct pci_device_id *id) > +{ > + return acpi_video_register(); > +} > + > +static void poulsbo_remove(struct pci_dev *pdev) > +{ > + acpi_video_unregister(); > +} > + > +static struct pci_driver poulsbo_driver = { > + .name = DRIVER_NAME, > + .id_table = pciidlist, > + .probe = poulsbo_probe, > + .remove = poulsbo_remove, > +}; > + > +static int __init poulsbo_init(void) > +{ > + return pci_register_driver(&poulsbo_driver); > +} > + > +static void __exit poulsbo_exit(void) > +{ > + pci_unregister_driver(&poulsbo_driver); > +} > + > +module_init(poulsbo_init); > +module_exit(poulsbo_exit); > + > +MODULE_AUTHOR("Lee, Chun-Yi "); > +MODULE_DESCRIPTION("Poulsbo Stub Driver"); > +MODULE_LICENSE("GPL"); > + > +MODULE_DEVICE_TABLE(pci, pciidlist); > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 8b31fdf..8807ae5 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -17,6 +17,8 @@ source "drivers/gpu/vga/Kconfig" > > source "drivers/gpu/drm/Kconfig" > > +source "drivers/gpu/stub/Kconfig" > + > config VGASTATE > tristate > default n