From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37210 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oy2Ol-0008VG-VK for qemu-devel@nongnu.org; Tue, 21 Sep 2010 08:56:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oy2Ok-0002QV-Ov for qemu-devel@nongnu.org; Tue, 21 Sep 2010 08:56:39 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:40416) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oy2Ok-0002QM-KI for qemu-devel@nongnu.org; Tue, 21 Sep 2010 08:56:38 -0400 Received: by iwn38 with SMTP id 38so5561425iwn.4 for ; Tue, 21 Sep 2010 05:56:37 -0700 (PDT) Message-ID: <4C98AB70.2000005@codemonkey.ws> Date: Tue, 21 Sep 2010 07:56:16 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 00/18] Monitor: split HMP and QMP dispatch tables References: <1284668464-15981-1-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1284668464-15981-1-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com On 09/16/2010 03:20 PM, Luiz Capitulino wrote: > The subject says it all: with this series applied we'll get different > dispatch tables for HMP and QMP, which has the side effect of making > QMP commands (such as qmp_capabilities) disappear from HMP's scope. > > This is also the beginning of the Monitor's redesign, which aims to > separate QMP, HMP and common code. > > There's a penalty, though. We're going to get a bit of duplication > during the process, like duplicated handlers entries in the > dispatch tables. > > We'll need more separation and a proper internal QMP interface to > solve that... > Acked-by: Anthony Liguori It all looks pretty straight forward. Nice work! Regards, Anthony Liguori > --- > Makefile | 2 +- > Makefile.target | 7 +- > monitor.c | 357 ++++++++----- > monitor.h | 1 - > qemu-monitor-qmp.hx | 1541 +++++++++++++++++++++++++++++++++++++++++++++++++++ > qemu-monitor.hx | 1361 +--------------------------------------------- > 6 files changed, 1774 insertions(+), 1495 deletions(-) > >