All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
	"Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v2] cryptodev: extend feature flags description
Date: Mon, 21 May 2018 10:13:47 +0000	[thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1F7BE7@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <20180518164018.2576-1-pablo.de.lara.guarch@intel.com>

Acked-by: Vipin Varghese <vipin.varghese@intel.com>

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, May 18, 2018 10:10 PM
> To: Varghese, Vipin <vipin.varghese@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH v2] cryptodev: extend feature flags description
> 
> Extend the description of cryptodev feature flags, adding extra information.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> 
> Changes in v2:
> - Rephrased the comment as per Vipin's comments
> - Added comment in cryptodev structure
> 
>  lib/librte_cryptodev/rte_cryptodev.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_cryptodev/rte_cryptodev.h
> b/lib/librte_cryptodev/rte_cryptodev.h
> index 261a359dc..2fb65638d 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -373,7 +373,8 @@ struct rte_cryptodev_info {
>  	uint8_t driver_id;			/**< Driver identifier */
>  	struct rte_pci_device *pci_dev;		/**< PCI information. */
> 
> -	uint64_t feature_flags;			/**< Feature flags */
> +	uint64_t feature_flags;
> +	/**< Feature flags exposes HW/SW features for the given device */
> 
>  	const struct rte_cryptodev_capabilities *capabilities;
>  	/**< Array of devices supported capabilities */ @@ -749,7 +750,7 @@
> struct rte_cryptodev {
>  	struct rte_cryptodev_ops *dev_ops;
>  	/**< Functions exported by PMD */
>  	uint64_t feature_flags;
> -	/**< Supported features */
> +	/**< Feature flags exposes HW/SW features for the given device */
>  	struct rte_device *device;
>  	/**< Backing device */
> 
> --
> 2.17.0

  reply	other threads:[~2018-05-21 10:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18 13:20 [PATCH] cryptodev: extend feature flags description Pablo de Lara
2018-05-18 14:23 ` Varghese, Vipin
2018-05-18 16:40 ` [PATCH v2] " Pablo de Lara
2018-05-21 10:13   ` Varghese, Vipin [this message]
2018-05-21 11:35   ` Akhil Goyal
2018-05-21 21:45     ` De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1F7BE7@BGSMSX101.gar.corp.intel.com \
    --to=vipin.varghese@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.