Re: [PATCH v1 4/9] app/procinfo: add code for debug port

From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Tahhan, Maryam" <maryam.tahhan@intel.com>
Cc: "Patel, Amol" <amol.patel@intel.com>,
	"Tummala, Sivaprasad" <sivaprasad.tummala@intel.com>,
	"Byrne, Stephen1" <stephen1.byrne@intel.com>,
	"Glynn, Michael J" <michael.j.glynn@intel.com>
Subject: Re: [PATCH v1 4/9] app/procinfo: add code for debug port
Date: Sat, 27 Oct 2018 07:09:55 +0000	[thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2B500B@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A3BE0A7@irsmsx110.ger.corp.intel.com>

<snipped>
> >
> > +char bdr_str[100];
> 
> #define for marco size would be good. Instead of hard code.

Yes, agreed.

<snipped>
> > +		struct rte_eth_link link = {0};
> 
> Initialize structs using memset here and in other places.
> 

Will change for v3

<snipped>
> > +			printf("\t  -- RSS len %u key (hex):",
> > +			       rss_conf.rss_key_len);
> > +			for (k = 0; k < rss_conf.rss_key_len; k++)
> > +				printf(" %x", rss_conf.rss_key[k]);
> > +			printf("\t  -- hf 0x%"PRIx64"\n",
> > +			       rss_conf.rss_hf);
> 
> Is this per port? not per queue. Can this be moved to outside of the queue for
> loop.

Yes, currently RSS is set for all rx queues so it is per port. I think I coded for upcoming feature rx RSS queue group,. I will correct and send v3.

> > +		}
> > +
> > +		printf("  - drop packet information\n");
> 
> Printf heading can be changed as it is printing input and output packets also.
> 
ok