From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Varghese, Vipin" <vipin.varghese@intel.com>
Subject: Re: [PATCH 07/19] net/ice: support MTU setting
Date: Fri, 23 Nov 2018 09:58:09 +0000
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1918@BGSMSX101.gar.corp.intel.com>
References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com>
 <1542956179-80951-8-git-send-email-wenzhuo.lu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Yang, Qiming"
 <qiming.yang@intel.com>, "Li, Xiaoyun" <xiaoyun.li@intel.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 2CF941B4CA
 for <dev@dpdk.org>; Fri, 23 Nov 2018 10:58:17 +0100 (CET)
In-Reply-To: <1542956179-80951-8-git-send-email-wenzhuo.lu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

HI Wenzhou,

Following is a thought but not an issue. Can you please let me know your th=
ought?

<snipped>

> +static int
> +ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) {
> +	struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
> +	struct rte_eth_dev_data *dev_data =3D pf->dev_data;
> +	uint32_t frame_size =3D mtu + ETHER_HDR_LEN
> +			      + ETHER_CRC_LEN + ICE_VLAN_TAG_SIZE;
> +
> +	if (rte_eal_process_type() =3D=3D RTE_PROC_SECONDARY)
> +		return -E_RTE_SECONDARY;
> +
> +	/* check if mtu is within the allowed range */
> +	if ((mtu < ETHER_MIN_MTU) || (frame_size > ICE_FRAME_SIZE_MAX))
> +		return -EINVAL;
> +

Should we set MTU > 1500 (Jumbo frame) if device is not configured to run w=
ith jumbo frame? If no, should we check the jumbo config is enabled for the=
 current device?

> +	/* mtu setting is forbidden if port is start */
> +	if (dev_data->dev_started) {
> +		PMD_DRV_LOG(ERR,
> +			    "port %d must be stopped before configuration",
> +			    dev_data->port_id);
> +		return -EBUSY;
> +	}
> +
> +	if (frame_size > ETHER_MAX_LEN)
> +		dev_data->dev_conf.rxmode.offloads |=3D
> +			DEV_RX_OFFLOAD_JUMBO_FRAME;
> +	else
> +		dev_data->dev_conf.rxmode.offloads &=3D
> +			~DEV_RX_OFFLOAD_JUMBO_FRAME;
> +
> +	dev_data->dev_conf.rxmode.max_rx_pkt_len =3D frame_size;
> +
> +	return 0;
> +}
> --
> 1.9.3