From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Pattan, Reshma" <reshma.pattan@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"Patel, Amol" <amol.patel@intel.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>
Subject: Re: [PATCH v8 1/7] app/procinfo: prepare for new debug functions
Date: Thu, 10 Jan 2019 08:53:38 +0000 [thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2EE771@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <4383677.neL5jlz7Vu@xps>
Hi Thomas,
snipped
>
> 10/01/2019 04:08, Varghese, Vipin:
> > snipped
> > >
> > > Hi Vipin,
> > >
> > > The code split in this v8 looks really better, except this patch
> > > which makes no sense alone.
> > Hi Thomas, I need this base patch as first one. These include the helper
> MACRO and include which pans out for next 7 patches.
> >
> > > I feel you can move these changes in next patches, where appropriate, isn't
> it?
> > Patches v2 to v7 uses common features from v1.
>
> At least, you should introduce the includes when needed.
As mentioned earlier these are used in v2 to v7.
> If you need this patch for introducing some macros, then rename it and
> explain the macros in the message.
The MACRO introduced in this patch are 'MAX_STRING_LEN, STATS_BDR_FMT and STATS_BDR_STR'. As per code contribution guideline I may have missed out the stipulation requesting for explaining the same.
>
>
> > > 07/01/2019 16:38, Vipin Varghese:
> > > > Update code base and meson build file to accommodate changes for
> > > > the new functionality.
> > > >
> > > > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > > > Acked-by: Reshma Pattan <reshma.pattan@intel.com>
> > > > ---
snipped
next prev parent reply other threads:[~2019-01-10 8:53 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 14:15 [PATCH v5 1/9] app/procinfo: add usage for new debug Vipin Varghese
2018-11-22 14:15 ` [PATCH v5 2/9] app/procinfo: add compare for new options Vipin Varghese
2018-11-22 14:15 ` [PATCH v5 3/9] app/procinfo: add prototype for debug instances Vipin Varghese
2018-11-22 14:15 ` [PATCH v5 4/9] app/procinfo: add support for show port Vipin Varghese
2018-11-22 14:15 ` [PATCH v5 5/9] app/procinfo: add support for show tm Vipin Varghese
2018-11-22 14:15 ` [PATCH v5 6/9] app/procinfo: add support for show crypto Vipin Varghese
2018-11-22 14:15 ` [PATCH v5 7/9] app/procinfo: add support for debug ring Vipin Varghese
2018-11-22 14:15 ` [PATCH v5 8/9] app/procinfo: add support for show mempool Vipin Varghese
2018-11-22 14:15 ` [PATCH v5 9/9] doc/procinfo: add information for debug options Vipin Varghese
2018-11-22 18:08 ` Mcnamara, John
2018-11-23 4:58 ` Varghese, Vipin
2018-12-03 5:49 ` [PATCH v6 0/9] app/proc-info: improve debug of proc-info tool Vipin Varghese
2018-12-03 5:49 ` [PATCH v6 1/9] app/procinfo: add usage for new debug Vipin Varghese
2018-12-12 14:14 ` Pattan, Reshma
2018-12-12 15:06 ` Varghese, Vipin
2018-12-13 5:08 ` [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool Vipin Varghese
2018-12-13 5:08 ` [PATCH v7 1/9] app/procinfo: add usage for new debug Vipin Varghese
2018-12-13 5:08 ` [PATCH v7 2/9] app/procinfo: add compare for new options Vipin Varghese
2018-12-13 5:08 ` [PATCH v7 3/9] app/procinfo: add prototype for debug instances Vipin Varghese
2018-12-13 5:08 ` [PATCH v7 4/9] app/procinfo: add support for show port Vipin Varghese
2018-12-13 5:08 ` [PATCH v7 5/9] app/procinfo: add support for show tm Vipin Varghese
2018-12-13 5:08 ` [PATCH v7 6/9] app/procinfo: add support for show crypto Vipin Varghese
2018-12-13 5:08 ` [PATCH v7 7/9] app/procinfo: add support for debug ring Vipin Varghese
2018-12-13 5:08 ` [PATCH v7 8/9] app/procinfo: add support for show iter mempool Vipin Varghese
2018-12-13 5:08 ` [PATCH v7 9/9] doc/procinfo: add information for debug options Vipin Varghese
2018-12-13 14:42 ` [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool Pattan, Reshma
2018-12-13 16:21 ` Varghese, Vipin
2018-12-22 21:02 ` Thomas Monjalon
2018-12-26 5:21 ` Varghese, Vipin
2018-12-26 21:33 ` Thomas Monjalon
2018-12-27 2:46 ` Varghese, Vipin
2018-12-27 9:32 ` Thomas Monjalon
2018-12-27 10:45 ` Varghese, Vipin
2019-01-07 15:38 ` [PATCH v8 0/7] app/proc-info: enhance " Vipin Varghese
2019-01-07 15:38 ` [PATCH v8 1/7] app/procinfo: prepare for new debug functions Vipin Varghese
2019-01-09 23:45 ` Thomas Monjalon
2019-01-10 3:08 ` Varghese, Vipin
2019-01-10 8:39 ` Thomas Monjalon
2019-01-10 8:53 ` Varghese, Vipin [this message]
2019-01-10 9:09 ` Thomas Monjalon
2019-01-10 21:36 ` [PATCH v9 0/6] app/proc-info: enhance debug of proc-info tool Vipin Varghese
2019-01-10 21:36 ` [PATCH v9 1/6] app/procinfo: add support for show port Vipin Varghese
2019-01-10 17:40 ` Thomas Monjalon
2019-01-11 3:57 ` Varghese, Vipin
2019-01-11 10:22 ` Thomas Monjalon
2019-01-10 21:36 ` [PATCH v9 2/6] app/procinfo: add support for show tm Vipin Varghese
2019-01-10 21:36 ` [PATCH v9 3/6] app/procinfo: add support for show crypto Vipin Varghese
2019-01-10 21:36 ` [PATCH v9 4/6] app/procinfo: add support for debug ring Vipin Varghese
2019-01-10 21:36 ` [PATCH v9 5/6] app/procinfo: add support for show mempool Vipin Varghese
2019-01-10 21:36 ` [PATCH v9 6/6] app/procinfo: add support for iter mempool Vipin Varghese
2019-01-11 14:46 ` [PATCH v9 0/6] app/proc-info: enhance debug of proc-info tool Thomas Monjalon
2019-01-14 0:07 ` Varghese, Vipin
2019-01-07 15:38 ` [PATCH v8 2/7] app/procinfo: add support for show port Vipin Varghese
2019-01-07 15:38 ` [PATCH v8 3/7] app/procinfo: add support for show tm Vipin Varghese
2019-01-07 15:38 ` [PATCH v8 4/7] app/procinfo: add support for show crypto Vipin Varghese
2019-01-07 15:38 ` [PATCH v8 5/7] app/procinfo: add support for debug ring Vipin Varghese
2019-01-07 15:38 ` [PATCH v8 6/7] app/procinfo: add support for show mempool Vipin Varghese
2019-01-07 15:38 ` [PATCH v8 7/7] app/procinfo: add support for iter mempool Vipin Varghese
2018-12-03 5:49 ` [PATCH v6 2/9] app/procinfo: add compare for new options Vipin Varghese
2018-12-03 5:49 ` [PATCH v6 3/9] app/procinfo: add prototype for debug instances Vipin Varghese
2018-12-03 5:49 ` [PATCH v6 4/9] app/procinfo: add support for show port Vipin Varghese
2018-12-03 5:49 ` [PATCH v6 5/9] app/procinfo: add support for show tm Vipin Varghese
2018-12-03 5:49 ` [PATCH v6 6/9] app/procinfo: add support for show crypto Vipin Varghese
2018-12-03 5:49 ` [PATCH v6 7/9] app/procinfo: add support for debug ring Vipin Varghese
2018-12-03 5:49 ` [PATCH v6 8/9] app/procinfo: add support for show iter mempool Vipin Varghese
2018-12-12 16:10 ` Pattan, Reshma
2018-12-13 2:26 ` Varghese, Vipin
2018-12-03 5:50 ` [PATCH v6 9/9] doc/procinfo: add information for debug options Vipin Varghese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2EE771@BGSMSX101.gar.corp.intel.com \
--to=vipin.varghese@intel.com \
--cc=amol.patel@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.