From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Varghese, Vipin" Subject: Re: [PATCH v6 4/8] eal: sys/queue.h implementation for windows Date: Thu, 28 Mar 2019 02:30:13 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D326E11@BGSMSX101.gar.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328022115.4660-1-anand.rawat@intel.com> <20190328022115.4660-5-anand.rawat@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Rawat, Anand" , "Kadam, Pallavi" , "Menon, Ranjit" , "Shaw, Jeffrey B" , "Richardson, Bruce" , "thomas@monjalon.net" To: "Rawat, Anand" , "dev@dpdk.org" Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B9ADD326D for ; Thu, 28 Mar 2019 03:30:21 +0100 (CET) In-Reply-To: <20190328022115.4660-5-anand.rawat@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anand, snipped >=20 > Adding sys/queue.h on windows for supporting common code. > This is implementation has BSD-3-Clause licensing. >=20 > Signed-off-by: Ranjit Menon > Signed-off-by: Anand Rawat > Reviewed-by: Jeff Shaw > --- > .../windows/eal/include/sys/queue.h | 320 ++++++++++++++++++ > 1 file changed, 320 insertions(+) > create mode 100644 lib/librte_eal/windows/eal/include/sys/queue.h >=20 > diff --git a/lib/librte_eal/windows/eal/include/sys/queue.h > b/lib/librte_eal/windows/eal/include/sys/queue.h > new file mode 100644 > index 000000000..5ee4916ad > --- /dev/null > +++ b/lib/librte_eal/windows/eal/include/sys/queue.h > @@ -0,0 +1,320 @@ > +/*- > + * SPDX-License-Identifier: BSD-3-Clause > + * > + * Copyright (c) 1991, 1993 > + * The Regents of the University of California. All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * 1. Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * 2. Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in th= e > + * documentation and/or other materials provided with the distributio= n. > + * 3. Neither the name of the University nor the names of its contributo= rs > + * may be used to endorse or promote products derived from this softw= are > + * without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' > AND > + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, > THE > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A > PARTICULAR PURPOSE > + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE > LIABLE > + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > CONSEQUENTIAL > + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF > SUBSTITUTE GOODS > + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > INTERRUPTION) > + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > CONTRACT, STRICT > + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN > ANY WAY > + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY > OF > + * SUCH DAMAGE. > + * > + */ Can you help me understand why this should not be=20 ``` # SPDX-License-Identifier: BSD-3-Clause -# Copyright(c) 2017 Intel Corporat= ion +# Copyright(c) 2017-2019 Intel Corporation ``` snipped