From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62449C43218 for ; Thu, 25 Apr 2019 15:51:24 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 6C62D2077C for ; Thu, 25 Apr 2019 15:51:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C62D2077C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E7D31B5D5; Thu, 25 Apr 2019 17:51:23 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 227DC1B5D1 for ; Thu, 25 Apr 2019 17:51:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 08:51:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,394,1549958400"; d="scan'208";a="226658133" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 25 Apr 2019 08:51:19 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 25 Apr 2019 08:51:19 -0700 Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 25 Apr 2019 08:51:19 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.225]) by BGSMSX102.gar.corp.intel.com ([169.254.2.128]) with mapi id 14.03.0415.000; Thu, 25 Apr 2019 21:21:16 +0530 From: "Varghese, Vipin" To: Suanming.Mou , "Pattan, Reshma" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] app/pdump: exits once primary app exited Thread-Index: AQHU+3PvpK4/OfOwwkSH+YBzP/84WqZNBN0g Date: Thu, 25 Apr 2019 15:51:16 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D33DEB0@BGSMSX101.gar.corp.intel.com> References: <1556210141-43153-1-git-send-email-mousuanming@huawei.com> In-Reply-To: <1556210141-43153-1-git-send-email-mousuanming@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTM0ZWRiNjctY2EzMy00MTNlLWE2ZWMtOTc1NWVlZWEzOGYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidUxUM1JJajNsXC9oMFJEcG5QWkJRV1NwSlhHZFV5U3ZHK0VmeHNuUDN1cDNqakRmanRMdFVkUDNBaUFTQWVMY1gifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/pdump: exits once primary app exited X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, snipped > @@ -847,6 +847,10 @@ struct parse_val { > pdump_rxtx(pt->rx_ring, pt->rx_vdev_id, &pt->stats); > if (pt->dir & RTE_PDUMP_FLAG_TX) > pdump_rxtx(pt->tx_ring, pt->tx_vdev_id, &pt->stats); > + > + /* Once primary exits, so will I. */ > + if (!rte_eal_primary_proc_alive(NULL)) > + quit_signal =3D 1; > } As per the current suggested code flow check is added to while loop in func= tion `dump_packets'.=20 Questions: 1. What is impact in performance with and without patch? 2. For various packet sizes and port speed what are delta in drops for pack= et capture? Note: If pdump application is still alive when primary is not running, prim= ary cannot be started. Is this a cue that pdump is still alive and has to b= e terminated? >=20 > static int > -- > 1.7.12.4