From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753097Ab0JMUPZ (ORCPT ); Wed, 13 Oct 2010 16:15:25 -0400 Received: from ch-smtp02.sth.basefarm.net ([80.76.149.213]:39539 "EHLO ch-smtp02.sth.basefarm.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752730Ab0JMUPY (ORCPT ); Wed, 13 Oct 2010 16:15:24 -0400 Message-ID: <4CB612F1.1080704@euromail.se> Date: Wed, 13 Oct 2010 22:13:37 +0200 From: Henrik Rydberg User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100922 Thunderbird/3.1.4 MIME-Version: 1.0 To: Henrik Rydberg CC: Jiri Kosina , Dmitry Torokhov , Philipp Merkel , Stephane Chatty , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] hid: egalax: Correct for device resolution report error References: <1286978302-30034-1-git-send-email-rydberg@euromail.se> <1286978302-30034-4-git-send-email-rydberg@euromail.se> In-Reply-To: <1286978302-30034-4-git-send-email-rydberg@euromail.se> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Originating-IP: 83.248.196.134 X-Scan-Result: No virus found in message 1P67hj-00051Y-8l. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1P67hj-00051Y-8l 94656b0169e694860f39885b3f97f7d3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2010 03:58 PM, Henrik Rydberg wrote: > The firmware of both supported devices report a X/Y maximum of 4096, > whereas in reality, it is eight times larger. Fixed with this patch. > > Signed-off-by: Henrik Rydberg > --- > drivers/hid/hid-egalax.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/hid/hid-egalax.c b/drivers/hid/hid-egalax.c > index 23f832b..3b490a3 100644 > --- a/drivers/hid/hid-egalax.c > +++ b/drivers/hid/hid-egalax.c > @@ -56,6 +56,7 @@ static int egalax_input_mapping(struct hid_device *hdev, struct hid_input *hi, > case HID_UP_GENDESK: > switch (usage->hid) { > case HID_GD_X: > + field->logical_maximum <<= 3; This makes the logical maximum increase by a factor of eight every time the module is loaded. > hid_map_usage(hi, usage, bit, max, > EV_ABS, ABS_MT_POSITION_X); > set_abs(input, ABS_MT_POSITION_X, field, 0); > @@ -63,6 +64,7 @@ static int egalax_input_mapping(struct hid_device *hdev, struct hid_input *hi, > set_abs(input, ABS_X, field, 0); > return 1; > case HID_GD_Y: > + field->logical_maximum <<= 3; Same here. > hid_map_usage(hi, usage, bit, max, > EV_ABS, ABS_MT_POSITION_Y); > set_abs(input, ABS_MT_POSITION_Y, field, 0); Will send new revisions of patches 3 and 5... Henrik