From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] Hitting 29 NIC limit Date: Thu, 14 Oct 2010 16:53:53 +0200 Message-ID: <4CB71981.6060405@redhat.com> References: <4CB6388A.30006@codemonkey.ws> <4CB6F275.2060204@redhat.com> <4CB6FD7E.7010606@codemonkey.ws> <4CB7044A.4050705@redhat.com> <4CB70F7E.30308@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anjali Kulkarni , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10778 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893Ab0JNOyV (ORCPT ); Thu, 14 Oct 2010 10:54:21 -0400 In-Reply-To: <4CB70F7E.30308@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 10/14/2010 04:11 PM, Anthony Liguori wrote: > On 10/14/2010 08:23 AM, Avi Kivity wrote: >> On 10/14/2010 02:54 PM, Anthony Liguori wrote: >>>>> The key is to make the virtio-net devices multifunction and to >>>>> fill out all 8 functions for each slot. >>>> >>>> This is unlikely to work right wrt pci hotplug. >>> >>> >>> Yes. Our hotplug design is based on devices.. This is wrong, it >>> should be based on bus-level concepts (like PCI slots). >>> >>>> If we want to support a large number of interfaces, we need true >>>> multiport cards. >>> >>> This magic here creates a multiport virtio-net card so I'm not >>> really sure what you're suggesting. It would certainly be nice to >>> make this all more user friendly (and make hotplug work). >>> >> >> The big issue is to fix hotplug. > > Yes, but this is entirely independent of multifunction devices. > > Today we shoe-horn hot remove into device_del. Instead, we should > have explicit bus-level interfaces for hot remove. I'm not saying multiplug is not the right way to approach this (it is). The only concern is to get hotplug right. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54398 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P6PCL-00051c-DD for qemu-devel@nongnu.org; Thu, 14 Oct 2010 10:54:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P6PCH-0002aA-3T for qemu-devel@nongnu.org; Thu, 14 Oct 2010 10:54:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P6PCG-0002Zt-Sb for qemu-devel@nongnu.org; Thu, 14 Oct 2010 10:54:21 -0400 Message-ID: <4CB71981.6060405@redhat.com> Date: Thu, 14 Oct 2010 16:53:53 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Hitting 29 NIC limit References: <4CB6388A.30006@codemonkey.ws> <4CB6F275.2060204@redhat.com> <4CB6FD7E.7010606@codemonkey.ws> <4CB7044A.4050705@redhat.com> <4CB70F7E.30308@codemonkey.ws> In-Reply-To: <4CB70F7E.30308@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anjali Kulkarni , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" On 10/14/2010 04:11 PM, Anthony Liguori wrote: > On 10/14/2010 08:23 AM, Avi Kivity wrote: >> On 10/14/2010 02:54 PM, Anthony Liguori wrote: >>>>> The key is to make the virtio-net devices multifunction and to >>>>> fill out all 8 functions for each slot. >>>> >>>> This is unlikely to work right wrt pci hotplug. >>> >>> >>> Yes. Our hotplug design is based on devices.. This is wrong, it >>> should be based on bus-level concepts (like PCI slots). >>> >>>> If we want to support a large number of interfaces, we need true >>>> multiport cards. >>> >>> This magic here creates a multiport virtio-net card so I'm not >>> really sure what you're suggesting. It would certainly be nice to >>> make this all more user friendly (and make hotplug work). >>> >> >> The big issue is to fix hotplug. > > Yes, but this is entirely independent of multifunction devices. > > Today we shoe-horn hot remove into device_del. Instead, we should > have explicit bus-level interfaces for hot remove. I'm not saying multiplug is not the right way to approach this (it is). The only concern is to get hotplug right. -- error compiling committee.c: too many arguments to function