From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [patch hail] remove duplicated stc_readport
Date: Tue, 26 Oct 2010 18:28:14 -0400 [thread overview]
Message-ID: <4CC755FE.7010604@garzik.org> (raw)
In-Reply-To: <20101026162322.605f5cc7@lembas.zaitcev.lan>
On 10/26/2010 06:23 PM, Pete Zaitcev wrote:
> On Tue, 26 Oct 2010 17:33:13 -0400
> Jeff Garzik<jeff@garzik.org> wrote:
>
>> it would be nice if a follow-up patch moved the hail_readport()
>> definition into a more generic, not-CLD-specific header such as
>> include/hail.h[1]
>
>> [1] which doesn't exist yet. maybe we could rename hail_log.h to
>> hail.h, and make hail.h a dumping ground for hail-generic items.
>
> Maybe. It sounds like a good idea. But it's also a slippery slope.
> I would rather have you look at it, when you have a moment.
>
> Also, how do I post a patch that renames a file? Just ask "git show"
> and send whatever comes out?
A patch that deletes a file and adds the file under a name is detected
by git as a rename. Or you can post a 'git pull' request.
Jeff
prev parent reply other threads:[~2010-10-26 22:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 19:47 [patch hail] remove duplicated stc_readport Pete Zaitcev
2010-10-26 21:33 ` Jeff Garzik
2010-10-26 22:23 ` Pete Zaitcev
2010-10-26 22:28 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC755FE.7010604@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.