[U-Boot] [PATCH V3] imx25: Fix reset

From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3] imx25: Fix reset
Date: Wed, 27 Oct 2010 16:43:46 +0200	[thread overview]
Message-ID: <4CC83AA2.2070900@emk-elektronik.de> (raw)
In-Reply-To: <1288190078-2770-1-git-send-email-weisserm@arcor.de>

Dear Matthias Weisser,
>  struct wdog_regs {
> -	u32 wcr;	/* Control */
> -	u32 wsr;	/* Service */
> -	u32 wrsr;	/* Reset Status */
> -	u32 wicr;	/* Interrupt Control */
> -	u32 wmcr;	/* Misc Control */
> +	u16 wcr;	/* Control */
> +	u16 wsr;	/* Service */
> +	u16 wrsr;	/* Reset Status */
> +	u16 wicr;	/* Interrupt Control */
> +	u16 wmcr;	/* Misc Control */
>  };
What catches my ARM-aware eye:

I do not know the hardware, but are those registers really
arranged on 2 byte boundaries (00, 02, 04, 06, 08, 0a, .. offsets)?
Probably yes, assuming your code is tested ;)

Or should there be a u16 filler between each register?

Best Regards,
Reinhard