From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757711Ab0J1MIv (ORCPT ); Thu, 28 Oct 2010 08:08:51 -0400 Received: from cantor.suse.de ([195.135.220.2]:51342 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752993Ab0J1MIs (ORCPT ); Thu, 28 Oct 2010 08:08:48 -0400 Message-ID: <4CC967CE.4020100@suse.cz> Date: Thu, 28 Oct 2010 14:08:46 +0200 From: Michal Marek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.1.11) Gecko/20100714 SUSE/3.0.6 Thunderbird/3.0.6 MIME-Version: 1.0 To: Mike Frysinger Cc: Hendrik Brueckner , Michael Holzheu , tabbott@ksplice.com, vda.linux@googlemail.com, hpa@linux.intel.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com, Sam Ravnborg Subject: Re: [PATCH] initramfs: Fix build break on symbol-prefixed archs References: <20100831082307.064687027@linux.vnet.ibm.com> <20100831083844.043619334@linux.vnet.ibm.com> <20101018103729.GA4122@linux.vnet.ibm.com> <20101019110801.GA4128@linux.vnet.ibm.com> <20101019213112.GA11432@merkur.ravnborg.org> <4CC8ABC7.5030003@suse.cz> <4CC8B6E4.7070200@suse.cz> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.10.2010 01:58, Mike Frysinger wrote: > On Wed, Oct 27, 2010 at 19:33, Michal Marek wrote: >> On 28.10.2010 01:10, Mike Frysinger wrote: >>> On Wed, Oct 27, 2010 at 18:46, Michal Marek wrote: >>>> Sorry I missed this thread. So your last patch >>>> (http://lkml.org/lkml/2010/10/19/488) did fix the Blackfin build >>>> failure? Can you submit it with a proper Signed-off-by and changelog? >>> >>> it shouldnt be a sep change. it should be squashed into the broken >>> one so that the result works. >> >> The breakage already happened and I don't want to rewind the branch now. > > if it isnt going to be merged until 2.6.38 merge window, i dont see > what the problem is with squashing a change into it. kbuild-2.6.git#kbuild has stuff meant for 2.6.37, In fact I'll be sending a pull request to Linus today. It would be great to sort the Blackfin & h8300 build failure first, though. > The previous commit works and >> the next will do as well if you submit the patch. > > if my change is going in after your bad commit, then you can squash it > with a simple `git commit --amend`. I know how to rewrite the branch, I just don't want to do it needlessly so that 'git pull' still works for people tracking the branch. Michal