[Qemu-devel] Re: [PATCH 02/40] elf: Add notes implementation

[Paolo Bonzini <pbonzini@redhat.com>]

On 11/01/2010 07:52 PM, Alexander Graf wrote:
>>> @@ -237,6 +242,8 @@ static uint64_t elf_default_translate(void *opaque, uint64_t addr)
>>>   ElfHandlers elf_default_handlers = {
>>>       .translate_fn = elf_default_translate,
>>>       .translate_opaque = NULL,
>>> +    .note_fn = elf_default_note,
>>> +    .note_opaque = NULL,
>>
>> Don't you have to add the definition to every user of translate_fn?
>>
>> Maybe it's better to guard calls through the pointers with an if.
>
> All users either pass NULL as translate (which means they default to
> elf_default_translate) or initialize their structure with the values in
> elf_default_translate :)

But do the MIPS users initialize note_fn?

Paolo