All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH v2 1/2] KVM: SVM: Replace svm_has() by standard Linux cpuid accessors
Date: Thu, 11 Nov 2010 16:50:10 +0200	[thread overview]
Message-ID: <4CDC02A2.6050306@redhat.com> (raw)
In-Reply-To: <20101111144606.GD5193@8bytes.org>

On 11/11/2010 04:46 PM, Joerg Roedel wrote:
> On Tue, Nov 09, 2010 at 04:15:42PM +0200, Avi Kivity wrote:
> >  -	if (nr == BP_VECTOR&&  !svm_has(SVM_FEATURE_NRIP)) {
> >  +	if (nr == BP_VECTOR&&  !static_cpu_has(X86_FEATURE_NRIPS)) {
>
> What is static_cpu_has

It's like boot_cpu_has, only it works by patching instead of a dynamic test.

> and why you use it only here and boot_cpu_has
> in all other places?

A nano optimization, this is a more commonly used path.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2010-11-11 14:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-09 14:15 [PATCH v2 0/2] Use host cpuid facilities Avi Kivity
2010-11-09 14:15 ` [PATCH v2 1/2] KVM: SVM: Replace svm_has() by standard Linux cpuid accessors Avi Kivity
2010-11-11 14:46   ` Joerg Roedel
2010-11-11 14:50     ` Avi Kivity [this message]
2010-11-11 15:10       ` Joerg Roedel
2010-11-09 14:15 ` [PATCH v2 2/2] KVM: Mask KVM_GET_SUPPORTED_CPUID data with Linux cpuid info Avi Kivity
2010-11-16 18:34 ` [PATCH v2 0/2] Use host cpuid facilities Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CDC02A2.6050306@redhat.com \
    --to=avi@redhat.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.