From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757575Ab0KLNV6 (ORCPT ); Fri, 12 Nov 2010 08:21:58 -0500 Received: from mail-qy0-f181.google.com ([209.85.216.181]:40808 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752711Ab0KLNV5 (ORCPT ); Fri, 12 Nov 2010 08:21:57 -0500 Message-ID: <4CDD3F71.5030908@codemonkey.ws> Date: Fri, 12 Nov 2010 07:21:53 -0600 From: Anthony Liguori User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Lightning/1.0b1 Thunderbird/3.0.10 MIME-Version: 1.0 To: Ian Molton CC: QEMU Developers , Rusty Russell , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, virtualization@lists.osdl.org, Alon Levy , Avi Kivity Subject: Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport References: <1097264455.965471288612409433.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> <4CCEC090.3050009@codemonkey.ws> <4CD1A406.3090909@collabora.co.uk> <4CD1A73B.2010406@codemonkey.ws> <4CD44759.5020500@collabora.co.uk> <4CDAD4D4.3070009@collabora.co.uk> <4CDADACC.4070405@codemonkey.ws> <4CDD2F9A.7000702@collabora.co.uk> In-Reply-To: <4CDD2F9A.7000702@collabora.co.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/12/2010 06:14 AM, Ian Molton wrote: > On 10/11/10 17:47, Anthony Liguori wrote: >> On 11/10/2010 11:22 AM, Ian Molton wrote: >>> Ping ? >> >> I think the best way forward is to post patches. > > I posted links to the git trees. I can post patches, but they are > *large*. Do you really want me to post them? Yes, and they have to be split up into something reviewable. > >> To summarize what I was trying to express in the thread, I think this is >> not the right long term architecture but am not opposed to it as a short >> term solution. I think having a new virtio device is a bad design choice >> but am not totally opposed to it. > > Ok! (I agree (that this should be a short term solution) :) ) > >> you want to go for the path of integration, you're going to have to fix >> all of the coding style issues and make the code fit into QEMU. Dropping >> a bunch of junk into target-i386/ is not making the code fit into QEMU. > > I agree. how about hw/gl for the renderer and hw/ for the virtio module? That would be fine. >> If you post just what you have now in patch form, I can try to provide >> more concrete advice ignoring the coding style problems. > > I can post patches, although I dont think LKML would appreciate the > volume! I can post them to the qemu list if you do. Yes, qemu is where I was suggesting you post them. Regards, Anthony Liguori > -Ian From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39030 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PGtZq-0005dO-9O for qemu-devel@nongnu.org; Fri, 12 Nov 2010 08:22:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PGtZl-0004Xi-UU for qemu-devel@nongnu.org; Fri, 12 Nov 2010 08:21:59 -0500 Received: from mail-qw0-f45.google.com ([209.85.216.45]:54869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PGtZl-0004XT-PH for qemu-devel@nongnu.org; Fri, 12 Nov 2010 08:21:57 -0500 Received: by qwj8 with SMTP id 8so12685qwj.4 for ; Fri, 12 Nov 2010 05:21:57 -0800 (PST) Message-ID: <4CDD3F71.5030908@codemonkey.ws> Date: Fri, 12 Nov 2010 07:21:53 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport References: <1097264455.965471288612409433.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> <4CCEC090.3050009@codemonkey.ws> <4CD1A406.3090909@collabora.co.uk> <4CD1A73B.2010406@codemonkey.ws> <4CD44759.5020500@collabora.co.uk> <4CDAD4D4.3070009@collabora.co.uk> <4CDADACC.4070405@codemonkey.ws> <4CDD2F9A.7000702@collabora.co.uk> In-Reply-To: <4CDD2F9A.7000702@collabora.co.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Molton Cc: linux-kernel@vger.kernel.org, Rusty Russell , QEMU Developers , virtualization@lists.linux-foundation.org, virtualization@lists.osdl.org, Alon Levy , Avi Kivity On 11/12/2010 06:14 AM, Ian Molton wrote: > On 10/11/10 17:47, Anthony Liguori wrote: >> On 11/10/2010 11:22 AM, Ian Molton wrote: >>> Ping ? >> >> I think the best way forward is to post patches. > > I posted links to the git trees. I can post patches, but they are > *large*. Do you really want me to post them? Yes, and they have to be split up into something reviewable. > >> To summarize what I was trying to express in the thread, I think this is >> not the right long term architecture but am not opposed to it as a short >> term solution. I think having a new virtio device is a bad design choice >> but am not totally opposed to it. > > Ok! (I agree (that this should be a short term solution) :) ) > >> you want to go for the path of integration, you're going to have to fix >> all of the coding style issues and make the code fit into QEMU. Dropping >> a bunch of junk into target-i386/ is not making the code fit into QEMU. > > I agree. how about hw/gl for the renderer and hw/ for the virtio module? That would be fine. >> If you post just what you have now in patch form, I can try to provide >> more concrete advice ignoring the coding style problems. > > I can post patches, although I dont think LKML would appreciate the > volume! I can post them to the qemu list if you do. Yes, qemu is where I was suggesting you post them. Regards, Anthony Liguori > -Ian