From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?P=E1draig_Brady?= Subject: Re: [PATCH 4/6] Ext4: fail if we try to use hole punch Date: Tue, 16 Nov 2010 16:20:43 +0000 Message-ID: <4CE2AF5B.7020500@draigBrady.com> References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-5-git-send-email-josef@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: david@fromorbit.com, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cmm@us.ibm.com, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com To: Josef Bacik Return-path: In-Reply-To: <1289840723-3056-5-git-send-email-josef@redhat.com> List-ID: On 15/11/10 17:05, Josef Bacik wrote: > Ext4 doesn't have the ability to punch holes yet, so make sure we ret= urn > EOPNOTSUPP if we try to use hole punching through fallocate. This su= pport can > be added later. Thanks, >=20 > Signed-off-by: Josef Bacik > --- > fs/ext4/extents.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) >=20 > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index 0554c48..35bca73 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int m= ode, loff_t offset, loff_t len) > struct ext4_map_blocks map; > unsigned int credits, blkbits =3D inode->i_blkbits; > =20 > + /* We only support the FALLOC_FL_KEEP_SIZE mode */ > + if (mode && (mode !=3D FALLOC_FL_KEEP_SIZE)) > + return -EOPNOTSUPP; > + > /* > * currently supporting (pre)allocate mode for extent-based > * files _only_ So for older versions of ext4 or other filesystems, how do we know that fallocate(...,FALLOC_FL_PUNCH_HOLE) is not supported. I.E. how do we detect at runtime that the call succeeded and didn't just do a normal fallocate()? cheers, P=E1draig. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754831Ab0KPQVV (ORCPT ); Tue, 16 Nov 2010 11:21:21 -0500 Received: from mail1.slb.deg.dub.stisp.net ([84.203.253.98]:18430 "HELO mail1.slb.deg.dub.stisp.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754441Ab0KPQVU (ORCPT ); Tue, 16 Nov 2010 11:21:20 -0500 Message-ID: <4CE2AF5B.7020500@draigBrady.com> Date: Tue, 16 Nov 2010 16:20:43 +0000 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 To: Josef Bacik CC: david@fromorbit.com, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cmm@us.ibm.com, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com Subject: Re: [PATCH 4/6] Ext4: fail if we try to use hole punch References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-5-git-send-email-josef@redhat.com> In-Reply-To: <1289840723-3056-5-git-send-email-josef@redhat.com> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/11/10 17:05, Josef Bacik wrote: > Ext4 doesn't have the ability to punch holes yet, so make sure we return > EOPNOTSUPP if we try to use hole punching through fallocate. This support can > be added later. Thanks, > > Signed-off-by: Josef Bacik > --- > fs/ext4/extents.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index 0554c48..35bca73 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len) > struct ext4_map_blocks map; > unsigned int credits, blkbits = inode->i_blkbits; > > + /* We only support the FALLOC_FL_KEEP_SIZE mode */ > + if (mode && (mode != FALLOC_FL_KEEP_SIZE)) > + return -EOPNOTSUPP; > + > /* > * currently supporting (pre)allocate mode for extent-based > * files _only_ So for older versions of ext4 or other filesystems, how do we know that fallocate(...,FALLOC_FL_PUNCH_HOLE) is not supported. I.E. how do we detect at runtime that the call succeeded and didn't just do a normal fallocate()? cheers, Pádraig. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id oAGGJk2A082802 for ; Tue, 16 Nov 2010 10:19:47 -0600 Received: from mail1.slb.deg.dub.stisp.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with SMTP id 46DBF1852FC for ; Tue, 16 Nov 2010 08:21:18 -0800 (PST) Received: from mail1.slb.deg.dub.stisp.net (mail1.slb.deg.dub.stisp.net [84.203.253.98]) by cuda.sgi.com with SMTP id b5FGCLhOa2V9WZ4J for ; Tue, 16 Nov 2010 08:21:18 -0800 (PST) Message-ID: <4CE2AF5B.7020500@draigBrady.com> Date: Tue, 16 Nov 2010 16:20:43 +0000 From: =?ISO-8859-1?Q?P=E1draig_Brady?= MIME-Version: 1.0 Subject: Re: [PATCH 4/6] Ext4: fail if we try to use hole punch References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-5-git-send-email-josef@redhat.com> In-Reply-To: <1289840723-3056-5-git-send-email-josef@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Josef Bacik Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com, cluster-devel@redhat.com, cmm@us.ibm.com, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org On 15/11/10 17:05, Josef Bacik wrote: > Ext4 doesn't have the ability to punch holes yet, so make sure we return > EOPNOTSUPP if we try to use hole punching through fallocate. This suppor= t can > be added later. Thanks, > = > Signed-off-by: Josef Bacik > --- > fs/ext4/extents.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > = > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index 0554c48..35bca73 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int mode,= loff_t offset, loff_t len) > struct ext4_map_blocks map; > unsigned int credits, blkbits =3D inode->i_blkbits; > = > + /* We only support the FALLOC_FL_KEEP_SIZE mode */ > + if (mode && (mode !=3D FALLOC_FL_KEEP_SIZE)) > + return -EOPNOTSUPP; > + > /* > * currently supporting (pre)allocate mode for extent-based > * files _only_ So for older versions of ext4 or other filesystems, how do we know that fallocate(...,FALLOC_FL_PUNCH_HOLE) is not supported. I.E. how do we detect at runtime that the call succeeded and didn't just do a normal fallocate()? cheers, P=E1draig. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?P=E1draig_Brady?= Date: Tue, 16 Nov 2010 16:21:21 -0000 Subject: [Ocfs2-devel] [PATCH 4/6] Ext4: fail if we try to use hole punch In-Reply-To: <1289840723-3056-5-git-send-email-josef@redhat.com> References: <1289840723-3056-1-git-send-email-josef@redhat.com> <1289840723-3056-5-git-send-email-josef@redhat.com> Message-ID: <4CE2AF5B.7020500@draigBrady.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Josef Bacik Cc: david@fromorbit.com, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cmm@us.ibm.com, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com On 15/11/10 17:05, Josef Bacik wrote: > Ext4 doesn't have the ability to punch holes yet, so make sure we return > EOPNOTSUPP if we try to use hole punching through fallocate. This support can > be added later. Thanks, > > Signed-off-by: Josef Bacik > --- > fs/ext4/extents.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index 0554c48..35bca73 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -3622,6 +3622,10 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len) > struct ext4_map_blocks map; > unsigned int credits, blkbits = inode->i_blkbits; > > + /* We only support the FALLOC_FL_KEEP_SIZE mode */ > + if (mode && (mode != FALLOC_FL_KEEP_SIZE)) > + return -EOPNOTSUPP; > + > /* > * currently supporting (pre)allocate mode for extent-based > * files _only_ So for older versions of ext4 or other filesystems, how do we know that fallocate(...,FALLOC_FL_PUNCH_HOLE) is not supported. I.E. how do we detect at runtime that the call succeeded and didn't just do a normal fallocate()? cheers, P?draig.