All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Chris Leech <christopher.leech@linux.intel.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 1/5] qt602240_ts: fix wrong sizeof in object table allocation
Date: Thu, 18 Nov 2010 20:30:31 +0900	[thread overview]
Message-ID: <4CE50E57.6070507@samsung.com> (raw)
In-Reply-To: <4CE50B09.2020507@samsung.com>

On 2010-11-18 오후 8:16, Joonyoung Shim wrote:
> Hi, Chris.
>
> On 2010-11-17 오전 5:41, Chris Leech wrote:
>> The kcalloc call for the object table is using sizeof(struct
>> qt602240_data)
>> when it should be using sizeof(struct qt6602240_object), resulting in
>> a larger
>> allocation than is required.
>>
>> Signed-off-by: Chris Leech<christopher.leech@linux.intel.com>
>
> Acked-by: Joonyoung Shim <jy0922@samsung.com>

Wrong e-mail address.

Acked-by: Joonyoung Shim <jy0922.shim@samsung.com>

>
> Thanks.
>
>> ---
>> drivers/input/touchscreen/qt602240_ts.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/input/touchscreen/qt602240_ts.c
>> b/drivers/input/touchscreen/qt602240_ts.c
>> index 66b26ad..0b92c9d 100644
>> --- a/drivers/input/touchscreen/qt602240_ts.c
>> +++ b/drivers/input/touchscreen/qt602240_ts.c
>> @@ -969,7 +969,7 @@ static int qt602240_initialize(struct
>> qt602240_data *data)
>> return error;
>>
>> data->object_table = kcalloc(info->object_num,
>> - sizeof(struct qt602240_data),
>> + sizeof(struct qt602240_object),
>> GFP_KERNEL);
>> if (!data->object_table) {
>> dev_err(&client->dev, "Failed to allocate memory\n");
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-input" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-11-18 11:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-16 20:41 [PATCH 0/4] qt602240_ts changes for Intel mid platform Chris Leech
2010-11-16 20:41 ` [PATCH 1/5] qt602240_ts: fix wrong sizeof in object table allocation Chris Leech
2010-11-18 11:16   ` Joonyoung Shim
2010-11-18 11:30     ` Joonyoung Shim [this message]
2010-11-16 20:41 ` [PATCH 2/5] qt602240_ts: move clearing of pending interrupt closer to request_threaded_irq Chris Leech
2010-11-18 12:53   ` Joonyoung Shim
2010-11-18 19:29     ` Chris Leech
2010-11-18 22:54       ` Dmitry Torokhov
2010-11-16 20:42 ` [PATCH 3/5] qt602240_ts: Trust factory configuration of touchscreen Chris Leech
2010-11-18 13:09   ` Joonyoung Shim
2010-11-18 19:41     ` Chris Leech
2010-11-16 20:42 ` [PATCH 4/5] qt602240_ts: add optional hooks for board specific reset logic Chris Leech
2010-11-18 11:32   ` Joonyoung Shim
2010-11-18 19:46     ` Chris Leech
2010-11-16 20:42 ` [PATCH 5/5] qt602240_ts: add mXT224 identifier to id_table, to match Intel mid firmware identifier Chris Leech
2010-11-18 11:34   ` Joonyoung Shim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE50E57.6070507@samsung.com \
    --to=jy0922.shim@samsung.com \
    --cc=christopher.leech@linux.intel.com \
    --cc=linux-input@vger.kernel.org \
    --subject='Re: [PATCH 1/5] qt602240_ts: fix wrong sizeof in object table allocation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.