From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51044 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PJ6cV-000768-1p
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 10:41:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1PJ6cT-0005LW-CH
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 10:41:54 -0500
Received: from e31.co.us.ibm.com ([32.97.110.149]:43793)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1PJ6cT-0005LE-5D
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 10:41:53 -0500
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com
	[9.17.195.227])
	by e31.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id oAIFSbpQ021742
	for <qemu-devel@nongnu.org>; Thu, 18 Nov 2010 08:28:37 -0700
Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	oAIFflbj215164
	for <qemu-devel@nongnu.org>; Thu, 18 Nov 2010 08:41:49 -0700
Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1])
	by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id oAIFjqYU024705
	for <qemu-devel@nongnu.org>; Thu, 18 Nov 2010 08:45:52 -0700
Message-ID: <4CE5492B.9060409@linux.vnet.ibm.com>
Date: Thu, 18 Nov 2010 09:41:31 -0600
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures
	and constants
References: <1289870175-14880-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1289870175-14880-2-git-send-email-mdroth@linux.vnet.ibm.com>
	<4CE508AA.7000405@redhat.com> <4CE547B8.7000309@linux.vnet.ibm.com>
In-Reply-To: <4CE547B8.7000309@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: agl@linux.vnet.ibm.com, Jes Sorensen <Jes.Sorensen@redhat.com>, qemu-devel@nongnu.org, ryanh@us.ibm.com, abeekhof@redhat.com, amit.shah@redhat.com

On 11/18/2010 09:35 AM, Michael Roth wrote:
>>> +/* listening fd, one for each service we're forwarding to remote 
>>> end */
>>> +typedef struct VPOForward {
>>> +    VPDriver *drv;
>>> +    int listen_fd;
>>> +    char service_id[VP_SERVICE_ID_LEN];
>>> +    QLIST_ENTRY(VPOForward) next;
>>> +} VPOForward;
>>
>> I am really not a fan of the typedefmeharder approach you are taking in
>> here, but others may disagree with me.
>
>
> Isn't typedef'ing structured types part of the qemu coding style 
> guidelines?

Yes, I think Jes was just looking for an excuse to say "typedefmeharder" :-)

Regards,

Anthony Liguori